[
https://issues.apache.org/jira/browse/BEAM-6635?focusedWorklogId=197163&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197163
]
ASF GitHub Bot logged work on BEAM-6635:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/19 21:11
Start Date: 11/Feb/19 21:11
Worklog Time Spent: 10m
Work Description: swegner commented on pull request #7795: [BEAM-6635]
increase maxHeapSize for test tasks
URL: https://github.com/apache/beam/pull/7795#discussion_r255694431
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -671,8 +671,12 @@ class BeamModulePlugin implements Plugin<Project> {
include "**/*TestCase.class"
}
- // Configure all test tasks to use JUnit
- project.tasks.withType(Test) { useJUnit {} }
+ project.tasks.withType(Test) {
+ // Configure all test tasks to use JUnit
+ useJUnit {}
+ // default maxHeapSize on gradle 5 is 512m, lets increase to handle
more demanding tests
+ maxHeapSize = '2g'
Review comment:
A desirable end state would be to have as many test tasks as possible using
the default lower memory. But, we will likely have many today that need higher
mem, for not obvious reasons.
This is code debt that would be nice-to-fix at some point, but I think it's
best if we decouple it from the Gradle 5 migration. It would be unfortunate if
we accidentally destabilized the tests due to this change and the Gradle 5
upgrade got rolled back.
So, my preference would be to file a JIRA to later come back and make this
configurable per-project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 197163)
Time Spent: 2h (was: 1h 50m)
> Fix java.lang.OutOfMemoryError: Java heap space on gradle 5
> -----------------------------------------------------------
>
> Key: BEAM-6635
> URL: https://issues.apache.org/jira/browse/BEAM-6635
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Michael Luckey
> Assignee: Michael Luckey
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> With gradle 5
> {noformat}
> All workers, including compilers and test executors, now start with 512MB of
> heap.
> The previous default was 1/4th of physical memory. Large projects may have to
> increase
> this setting on the relevant tasks, e.g. JavaCompile or Test.
> {noformat}
> This change cause some of our test to fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
