[
https://issues.apache.org/jira/browse/BEAM-10943?focusedWorklogId=565579&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-565579
]
ASF GitHub Bot logged work on BEAM-10943:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Mar/21 00:18
Start Date: 13/Mar/21 00:18
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #14222:
URL: https://github.com/apache/beam/pull/14222#discussion_r593523153
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/CalciteQueryPlanner.java
##########
@@ -92,8 +95,20 @@ public CalciteQueryPlanner(JdbcConnection connection,
Collection<RuleSet> ruleSe
@Override
public QueryPlanner createPlanner(
JdbcConnection jdbcConnection, Collection<RuleSet> ruleSets) {
+ loadBuiltinFunctions(jdbcConnection);
Review comment:
They don't. That's the point of this PR. The functions provided by
`BeamBuiltinFunctionProvider` are completely unused in ZetaSQL, so I figured we
don't want them in the catalog in the first place. Otherwise, when I add
functions from the jdbcConnection to the ZetaSQL catalog to enable
`registerUdf`, I will have to have some other way to filter out builtins, or
else they will conflict with the ZetaSQL builtins that are actually used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 565579)
Time Spent: 50m (was: 40m)
> Support SqlTransform.registerUdf in ZetaSQL dialect
> ---------------------------------------------------
>
> Key: BEAM-10943
> URL: https://issues.apache.org/jira/browse/BEAM-10943
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql-zetasql
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: P2
> Labels: stale-assigned
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
