[
https://issues.apache.org/jira/browse/BEAM-11934?focusedWorklogId=565584&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-565584
]
ASF GitHub Bot logged work on BEAM-11934:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Mar/21 00:31
Start Date: 13/Mar/21 00:31
Worklog Time Spent: 10m
Work Description: nehsyc commented on a change in pull request #14164:
URL: https://github.com/apache/beam/pull/14164#discussion_r593525983
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java
##########
@@ -314,12 +349,16 @@ public void validate(PipelineOptions options) {
"Must use windowed writes when applying %s to an unbounded
PCollection",
WriteFiles.class.getSimpleName());
// The reason for this is https://issues.apache.org/jira/browse/BEAM-1438
- // and similar behavior in other runners.
- checkArgument(
- getComputeNumShards() != null || getNumShardsProvider() != null,
- "When applying %s to an unbounded PCollection, "
- + "must specify number of output shards explicitly",
- WriteFiles.class.getSimpleName());
+ // and similar behavior in other runners. Runners can choose to ignore
this check and perform
+ // runner determined sharding for unbounded data by overriding the option
Review comment:
Resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 565584)
Time Spent: 2h 20m (was: 2h 10m)
> GCS streaming file sink uses runner determined sharding
> -------------------------------------------------------
>
> Key: BEAM-11934
> URL: https://issues.apache.org/jira/browse/BEAM-11934
> Project: Beam
> Issue Type: Improvement
> Components: io-java-files, io-java-gcp
> Reporter: Siyuan Chen
> Assignee: Siyuan Chen
> Priority: P1
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Integrate file sink with shardable `GroupIntoBatches` (BEAM-10475) to allow
> runner determined dynamic sharding for streaming use cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
