[ 
https://issues.apache.org/jira/browse/BEAM-11648?focusedWorklogId=565942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-565942
 ]

ASF GitHub Bot logged work on BEAM-11648:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Mar/21 17:04
            Start Date: 14/Mar/21 17:04
    Worklog Time Spent: 10m 
      Work Description: chamikaramj commented on a change in pull request 
#11767:
URL: https://github.com/apache/beam/pull/11767#discussion_r593930566



##########
File path: 
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java
##########
@@ -135,16 +135,36 @@
 import org.junit.rules.TestRule;
 import org.junit.runner.Description;
 import org.junit.runner.RunWith;
-import org.junit.runners.JUnit4;
+import org.junit.runners.Parameterized;

Review comment:
       I didn't look into tests in detail yet but given the extremely large 
change and number of potential users, we should try to get close to 100% code 
coverage and 100% test parity with streaming inserts (both unit and 
integration).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 565942)
    Time Spent: 27h 40m  (was: 27.5h)

> Implement new BigQuery sink (Vortex)
> ------------------------------------
>
>                 Key: BEAM-11648
>                 URL: https://issues.apache.org/jira/browse/BEAM-11648
>             Project: Beam
>          Issue Type: New Feature
>          Components: extensions-java-gcp
>            Reporter: Reuven Lax
>            Assignee: Reuven Lax
>            Priority: P2
>          Time Spent: 27h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to