[
https://issues.apache.org/jira/browse/BEAM-10708?focusedWorklogId=566186&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566186
]
ASF GitHub Bot logged work on BEAM-10708:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Mar/21 13:24
Start Date: 15/Mar/21 13:24
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#14176:
URL: https://github.com/apache/beam/pull/14176#discussion_r594330262
##########
File path: sdks/python/setup.py
##########
@@ -131,6 +131,10 @@ def get_version():
# Avro 1.9.2 for python3 was broken. The issue was fixed in version 1.9.2.1
'avro-python3>=1.8.1,!=1.9.2,<1.10.0',
'crcmod>=1.7,<2.0',
+ # dataclasses backport for Python 3.6. No version boundary so that Python
+ # picks the correct one based on its version. For more details, see
+ # https://pypi.org/project/dataclasses/
+ 'dataclasses',
Review comment:
```suggestion
'dataclasses;python_version<"3.7"',
```
WDYT about making it explicit like this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 566186)
Time Spent: 11.5h (was: 11h 20m)
> InteractiveRunner cannot execute pipeline with cross-language transform
> -----------------------------------------------------------------------
>
> Key: BEAM-10708
> URL: https://issues.apache.org/jira/browse/BEAM-10708
> Project: Beam
> Issue Type: Bug
> Components: cross-language
> Reporter: Brian Hulette
> Assignee: Ning Kang
> Priority: P2
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
> The InteractiveRunner crashes when given a pipeline that includes a
> cross-language transform.
> Here's the example I tried to run in a jupyter notebook:
> {code:python}
> p = beam.Pipeline(InteractiveRunner())
> pc = (p | SqlTransform("""SELECT
> CAST(1 AS INT) AS `id`,
> CAST('foo' AS VARCHAR) AS `str`,
> CAST(3.14 AS DOUBLE) AS `flt`"""))
> df = interactive_beam.collect(pc)
> {code}
> The problem occurs when
> [pipeline_fragment.py|https://github.com/apache/beam/blob/dce1eb83b8d5137c56ac58568820c24bd8fda526/sdks/python/apache_beam/runners/interactive/pipeline_fragment.py#L66]
> creates a copy of the pipeline by [writing it to proto and reading it
> back|https://github.com/apache/beam/blob/dce1eb83b8d5137c56ac58568820c24bd8fda526/sdks/python/apache_beam/runners/interactive/pipeline_fragment.py#L120].
> Reading it back fails because some of the pipeline is not written in Python.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)