[
https://issues.apache.org/jira/browse/BEAM-4164?focusedWorklogId=197692&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197692
]
ASF GitHub Bot logged work on BEAM-4164:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Feb/19 17:02
Start Date: 12/Feb/19 17:02
Worklog Time Spent: 10m
Work Description: echauchot commented on issue #7751: [BEAM-4164]
[BEAM-6591] Refactor, improve and fix CassandraIO
URL: https://github.com/apache/beam/pull/7751#issuecomment-462843882
@adejanovski is busy (and not payed to work on Beam :) ) @kennknowles can
you please take a look? Indeed I would like this PR to be merged so that [this
other one](https://github.com/apache/beam/pull/7340) that already waited too
long uses embedded cassandra in its test. It is only a refactoring of the
production code + improvement of test code. The only part that requires
Cassandra knowledge is the "fix split" commit which was already seen by
@adejanovski who is a Cassandra consultant.
Regarding the history: I have already squashed history to isolable commits
for both ease the review of the refactoring and allow an easy rollback of the
refactoring if need. I think the history should not be squashed more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 197692)
Time Spent: 3h (was: 2h 50m)
> Make unit tests of CassandraIO use embeded server
> -------------------------------------------------
>
> Key: BEAM-4164
> URL: https://issues.apache.org/jira/browse/BEAM-4164
> Project: Beam
> Issue Type: Test
> Components: io-java-cassandra
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Labels: triaged
> Time Spent: 3h
> Remaining Estimate: 0h
>
> The UT currently use a mock of the cassandra server. It would be good to do
> the tests using embeded Cassandra instance to be as close as possible from a
> real Cassandra server in the UT. Why not the one from cassandra-unit
> ([https://mvnrepository.com/artifact/org.cassandraunit/cassandra-unit/3.3.0.2])
> ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
