[
https://issues.apache.org/jira/browse/BEAM-5628?focusedWorklogId=566578&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566578
]
ASF GitHub Bot logged work on BEAM-5628:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Mar/21 22:09
Start Date: 15/Mar/21 22:09
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #14185:
URL: https://github.com/apache/beam/pull/14185#issuecomment-799787858
LGTM. @pabloem , just in case - this removal was discussed on dev@:
https://lists.apache.org/thread.html/rfca8b756aaeaf57069ed6f5b3026f94b1a7e11bbd6b212d36fdce5e2%40%3Cdev.beam.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 566578)
Time Spent: 2h 40m (was: 2.5h)
> VcfIO is not Python3-compatible and there are no plans to make it compatible.
> -----------------------------------------------------------------------------
>
> Key: BEAM-5628
> URL: https://issues.apache.org/jira/browse/BEAM-5628
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Priority: P3
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Several VcfIO tests fail in Python 3 with TypeError: cannot use a string
> pattern on a bytes-like object
>
> ERROR: test_read_after_splitting (apache_beam.io.vcfio_test.VcfSourceTest)
> "
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> ""/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/io/vcfio_test.py"",
> line 336, in test_read_after_splitting
> ] split_records.extend(source_test_utils.read_from_source(*source_info))
> ] File
> ""/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/io/source_test_utils.py"",
> line 101, in read_from_source
> for value in reader:
> File
> ""/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/io/vcfio.py"",
> line 264, in read_records
> for line in record_iterator:
> File
> ""/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/io/vcfio.py"",
> line 330, in __next__
> record = next(self._vcf_reader)
> File
> ""/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/target/.tox/py3/lib/python3.5/site-packages/vcf/parser.py"",
> line 543, in __next__
> row = self._row_pattern.split(line.rstrip())
> TypeError: cannot use a string pattern on a bytes-like object
> "
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
