[
https://issues.apache.org/jira/browse/BEAM-10402?focusedWorklogId=568715&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-568715
]
ASF GitHub Bot logged work on BEAM-10402:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/21 01:15
Start Date: 19/Mar/21 01:15
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #14254:
URL: https://github.com/apache/beam/pull/14254#discussion_r597336721
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/BeamZetaSqlCalcRel.java
##########
@@ -299,7 +295,7 @@ private void outputRow(TimestampedFuture c,
OutputReceiver<Row> r) throws Interr
try {
v = c.future().get();
} catch (ExecutionException e) {
- throw (RuntimeException) e.getCause();
+ throw new RuntimeException(checkArgumentNotNull(e.getCause()));
Review comment:
Sorry, I missed this on the first pass. We want `RuntimeException` to be
passed through without modification if possible. I believe this will work:
```
if (e.getCause() instanceof RuntimeException) {
throw (RuntimeException) e.getCause();
}
throw new RuntimeException(e);
```
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/BeamZetaSqlCalcRel.java
##########
@@ -169,12 +169,10 @@ private static TimestampedFuture create(Instant t,
Future<Value> f) {
private final Schema outputSchema;
private final String defaultTimezone;
private final boolean verifyRowValues;
+ private transient List<Integer> referencedColumns = ImmutableList.of();
Review comment:
Findbugs is unhappy with these two lines. Tag them with
`@SuppressFBWarnings("SE_TRANSIENT_FIELD_NOT_RESTORED")`
Also need: `import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 568715)
Time Spent: 19.5h (was: 19h 20m)
> [Umbrella] Eliminate nullability errors from Beam Java
> ------------------------------------------------------
>
> Key: BEAM-10402
> URL: https://issues.apache.org/jira/browse/BEAM-10402
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Priority: P1
> Labels: Clarified, starter
> Time Spent: 19.5h
> Remaining Estimate: 0h
>
> I enabled the checker framework and the core SDK exceeds 100 nullability
> errors immediately. We should make this number zero, since nullability errors
> are solved problem in computer science and they do periodically impact Beam.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
