[ 
https://issues.apache.org/jira/browse/BEAM-9185?focusedWorklogId=569037&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-569037
 ]

ASF GitHub Bot logged work on BEAM-9185:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Mar/21 18:22
            Start Date: 19/Mar/21 18:22
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on a change in pull request #14251:
URL: https://github.com/apache/beam/pull/14251#discussion_r597871620



##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -283,6 +283,8 @@ After following one of these processes you should manually 
update `CHANGES.md` o
      
[version.py](https://github.com/apache/beam/blob/release-2.6.0/sdks/python/apache_beam/version.py#L21),
      
[build.gradle](https://github.com/apache/beam/blob/release-2.6.0/runners/google-cloud-dataflow-java/build.gradle#L39),
      
[gradle.properties](https://github.com/apache/beam/blob/release-2.16.0/gradle.properties#L27)
+     
+**ATTENTION:** The Release Candidate Number ``rc_num`` is an optional 
parameter to add the version of the release candidate.

Review comment:
       I am not sure I understand the release flow from the guide - why is the 
RC number optional?
   
   Could we explain what the process will look like, in particular, at which 
point RC artifacts will be created and at which point they will be published to 
PyPi (I am guessing it is before the voting email is sent)? So both RC and 
non-RC artifacts will be built ahead of the voting email, but only RC artifacts 
be published to pypi?
   
   I think it makes sense to update the voting email template  
(https://github.com/benWize/beam/blob/BEAM-9185/website/www/site/content/en/contribute/release-guide.md#9-vote-and-validate-release-candidate)
 to point out that Python RC artifacts can be tried from PyPi .




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 569037)
    Time Spent: 2h  (was: 1h 50m)

> Publish pre-release python artifacts (RCs) to PyPI
> --------------------------------------------------
>
>                 Key: BEAM-9185
>                 URL: https://issues.apache.org/jira/browse/BEAM-9185
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Ahmet Altay
>            Assignee: Benjamin Gonzalez
>            Priority: P3
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> This was discussed in the mailing list and there was consensus [1].
> Remaining part for pypi would be updating the release process such as:
>  * New RC versioned artifacts are generated along with actual non-RC 
> versioned artifacts.
>  * RC versioned artifacts are published to pypi.
>  [1] 
> [https://lists.apache.org/thread.html/f071f8ab9f115636b9e6a6cabcfccbe2bb980d4394fe5581c59a4db6%40%3Cdev.beam.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to