[
https://issues.apache.org/jira/browse/BEAM-12010?focusedWorklogId=569075&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-569075
]
ASF GitHub Bot logged work on BEAM-12010:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/21 19:35
Start Date: 19/Mar/21 19:35
Worklog Time Spent: 10m
Work Description: amaliujia commented on a change in pull request #14265:
URL: https://github.com/apache/beam/pull/14265#discussion_r597930454
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
##########
@@ -89,7 +89,9 @@
public class ZetaSQLQueryPlanner implements QueryPlanner {
// TODO(BEAM-11747) Re-enable BeamJavaUdfCalcRule by default when it is safe
to do so.
public static final Collection<RelOptRule> DEFAULT_CALC =
-
ImmutableList.<RelOptRule>builder().add(BeamZetaSqlCalcRule.INSTANCE).build();
+ ImmutableList.<RelOptRule>builder()
+ .add(BeamZetaSqlCalcRule.INSTANCE, BeamZetaSqlCalcMergeRule.INSTANCE)
Review comment:
Will it make sense to create two RuleSets? One for each dialect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 569075)
Time Spent: 1h (was: 50m)
> CalcMergeRule should not merge BeamCalcRel and BeamZetaSqlCalcRel.
> ------------------------------------------------------------------
>
> Key: BEAM-12010
> URL: https://issues.apache.org/jira/browse/BEAM-12010
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql-zetasql
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: P2
> Fix For: 2.30.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Once we implement Calc splitting, CalcMergeRule will attempt to merge Calcs
> back together, which defeats the purpose of splitting them in the first
> place. We will need to narrow the merge conditions, to prevent incompatible
> Calcs from being merged.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
