[
https://issues.apache.org/jira/browse/BEAM-6663?focusedWorklogId=198193&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-198193
]
ASF GitHub Bot logged work on BEAM-6663:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Feb/19 16:20
Start Date: 13/Feb/19 16:20
Worklog Time Spent: 10m
Work Description: echauchot commented on pull request #7831: [BEAM-6663]
Override toString to get json serialized version of the Options
URL: https://github.com/apache/beam/pull/7831
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 198193)
Time Spent: 10m
Remaining Estimate: 0h
> SerializablePipelineOptions should override toString()
> ------------------------------------------------------
>
> Key: BEAM-6663
> URL: https://issues.apache.org/jira/browse/BEAM-6663
> Project: Beam
> Issue Type: Improvement
> Components: runner-core
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Many runners, store both options and SerializableOptions in their context
> whereas SerializableOptions stores both Options and json serialized Options.
> Options can be obtain by SerializableOptions.get() and json cannot be
> obtained. I propose to use only SerializableOptions inside the runners (as
> they all have serialization issues) and simply override toString to get the
> json version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
