[
https://issues.apache.org/jira/browse/BEAM-12007?focusedWorklogId=570403&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-570403
]
ASF GitHub Bot logged work on BEAM-12007:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/21 12:38
Start Date: 23/Mar/21 12:38
Worklog Time Spent: 10m
Work Description: haraldrombaut commented on a change in pull request
#14294:
URL: https://github.com/apache/beam/pull/14294#discussion_r599528698
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java
##########
@@ -1093,14 +1090,7 @@ public void processElement(ProcessContext c) throws
IOException, SizeLimitExceed
}
// NOTE: The record id is always null.
- output.add(
- OutgoingMessage.of(
- com.google.pubsub.v1.PubsubMessage.newBuilder()
- .setData(ByteString.copyFrom(payload))
- .putAllAttributes(attributes)
- .build(),
- c.timestamp().getMillis(),
- null));
+ output.add(OutgoingMessage.of(message, c.timestamp().getMillis(),
null));
Review comment:
The unbounded sink already uses this static method, where the
com.google.pubsub.v1.PubsubMessage is being created from the PubsubIO
PubsubMessage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 570403)
Time Spent: 50m (was: 40m)
> Set message ordering key for Google Pubsub
> ------------------------------------------
>
> Key: BEAM-12007
> URL: https://issues.apache.org/jira/browse/BEAM-12007
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Victor Devos
> Priority: P2
> Labels: PubSubIO, gcp, pubsub, pubsubio
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Message ordering is currently not supported on the producer side.
> [https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubMessage.java#L44]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
