[
https://issues.apache.org/jira/browse/BEAM-12033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kyle Weaver updated BEAM-12033:
-------------------------------
Description:
Numeric values in ZetaSQL are subject to constraints: they must fall within
certain hardcoded limits, and the scale also cannot exceed 9. Currently we have
stricter constraints than these when preparing the expression in
BeamZetaSqlCalcRel due to BEAM-12046. However, to force BeamCalcRel to have
correct behavior, we should check the constraints earlier, during expression
conversion.
https://github.com/google/zetasql/blob/697da738be2af3b6b9492c73c55616d8b9fed0b6/javatests/com/google/zetasql/ValueTest.java#L727-L745
was:
Numeric values in ZetaSQL are subject to constraints: they must fall within
certain hardcoded limits, and the scale also cannot exceed 9. Currently we have
stricter constraints than these when preparing the expression in
BeamZetaSqlCalcRel due to BEAM-12046. However, to force BeamCalcRel to have the
same behavior, we should check the constraints earlier, during expression
conversion.
https://github.com/google/zetasql/blob/697da738be2af3b6b9492c73c55616d8b9fed0b6/javatests/com/google/zetasql/ValueTest.java#L727-L745
> Validate casts from double literals to numeric during expression conversion.
> ----------------------------------------------------------------------------
>
> Key: BEAM-12033
> URL: https://issues.apache.org/jira/browse/BEAM-12033
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql-zetasql
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: P2
>
> Numeric values in ZetaSQL are subject to constraints: they must fall within
> certain hardcoded limits, and the scale also cannot exceed 9. Currently we
> have stricter constraints than these when preparing the expression in
> BeamZetaSqlCalcRel due to BEAM-12046. However, to force BeamCalcRel to have
> correct behavior, we should check the constraints earlier, during expression
> conversion.
> https://github.com/google/zetasql/blob/697da738be2af3b6b9492c73c55616d8b9fed0b6/javatests/com/google/zetasql/ValueTest.java#L727-L745
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
