[ 
https://issues.apache.org/jira/browse/BEAM-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768626#comment-16768626
 ] 

Ahmet Altay commented on BEAM-5731:
-----------------------------------

[https://github.com/apache/beam/pull/7842] - introduces this as a breaking 
change; in line with Python's change to its sorting operations.

 

Specifically, Top.Of and Top.PerKey will not accept a compare parameter in 
python 3.

 

> Disable compare parameter in Top.Of() combiner when executing in Python 3.
> --------------------------------------------------------------------------
>
>                 Key: BEAM-5731
>                 URL: https://issues.apache.org/jira/browse/BEAM-5731
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Valentyn Tymofieiev
>            Assignee: Robert Bradshaw
>            Priority: Minor
>              Labels: triaged
>             Fix For: 2.11.0
>
>
> Removing `compare` parameter in Top.Of() will be a more consistent API with 
> `sorted()` function in Python 3. We should also evaluate whether similar 
> changes would be  reasonable in other places in Beam SDK.
> See also: https://github.com/apache/beam/pull/6570#issuecomment-429176130.
> cc [~altay] [~juta] [~robertwb]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to