[
https://issues.apache.org/jira/browse/BEAM-6655?focusedWorklogId=198904&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-198904
]
ASF GitHub Bot logged work on BEAM-6655:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Feb/19 20:05
Start Date: 14/Feb/19 20:05
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #7819: [BEAM-6655]
Initial support for progress reporting over the FnAPI.
URL: https://github.com/apache/beam/pull/7819#discussion_r256990714
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -148,8 +148,13 @@ def try_split(self, fraction_of_remainder,
total_buffer_size):
# We are "finished" with the (non-existent) previous element.
current_element_progress = 1
else:
- # TODO(SDF): Get actual progress of current element.
- current_element_progress = 0.5
+ current_element_progress_object = (
+ self.receivers[0].current_element_progress())
+ if current_element_progress_object is None:
+ current_element_progress = 0.5
Review comment:
Shouldn't we return `0.0` or a special value like `-1` to indicate progress
is unknown?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 198904)
Time Spent: 0.5h (was: 20m)
> Support progress reporting over FnAPI
> -------------------------------------
>
> Key: BEAM-6655
> URL: https://issues.apache.org/jira/browse/BEAM-6655
> Project: Beam
> Issue Type: New Feature
> Components: beam-model, sdk-java-harness, sdk-py-harness
> Reporter: Robert Bradshaw
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
