[
https://issues.apache.org/jira/browse/BEAM-10884?focusedWorklogId=573790&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-573790
]
ASF GitHub Bot logged work on BEAM-10884:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Mar/21 22:59
Start Date: 29/Mar/21 22:59
Worklog Time Spent: 10m
Work Description: dpcollins-google commented on a change in pull request
#14365:
URL: https://github.com/apache/beam/pull/14365#discussion_r603664447
##########
File path: sdks/java/extensions/protobuf/src/test/proto/payload_messages.proto
##########
@@ -42,3 +42,18 @@ message SimpleMessage {
int32 id = 1;
string name = 2;
}
+
+message NameMessage {
Review comment:
possible nit: I'd use less-simple messages, at least one of which has a
submessage or repeated field? TestMessage with ItMessage above would work well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 573790)
Time Spent: 2.5h (was: 2h 20m)
> Add Proto support to Pubsub table provider
> ------------------------------------------
>
> Key: BEAM-10884
> URL: https://issues.apache.org/jira/browse/BEAM-10884
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Piotr Szuberski
> Assignee: Fernando Morales
> Priority: P3
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
