[
https://issues.apache.org/jira/browse/BEAM-12014?focusedWorklogId=574360&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-574360
]
ASF GitHub Bot logged work on BEAM-12014:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Mar/21 19:36
Start Date: 30/Mar/21 19:36
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #14372:
URL: https://github.com/apache/beam/pull/14372#discussion_r604378234
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryAvroUtilsTest.java
##########
@@ -99,28 +103,30 @@ public void testConvertGenericRecordToTableRow() throws
Exception {
// type. AvroCoder can't apply logical types to Schemas directly, so we
need to get the
// Schema for the Bird class defined below, then replace the field used to
test NUMERIC with
// a field that has the appropriate Schema.
- BigDecimal birthdayMoney = new BigDecimal("123456789.123456789");
- Schema birthdayMoneySchema = Schema.create(Type.BYTES);
- LogicalType birthdayMoneyLogicalType =
- LogicalTypes.decimal(birthdayMoney.precision(), birthdayMoney.scale());
+ BigDecimal bigDecimal =
+ new BigDecimal(
+
"578960446186580977117854925043439539266.34992332820282019728792003956564819967");
Review comment:
If you're going to use this for both NUMERIC and BIGNUMERIC tests, can
you keep the value within the supported range for both? I think the prior value
`123456789.123456789` would work fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 574360)
Time Spent: 0.5h (was: 20m)
> BigqueryIO BigNumeric Datatype Support
> --------------------------------------
>
> Key: BEAM-12014
> URL: https://issues.apache.org/jira/browse/BEAM-12014
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Vachan Shetty
> Assignee: Vachan Shetty
> Priority: P2
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Add support for the BigNumeric datatype.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
