[
https://issues.apache.org/jira/browse/BEAM-11747?focusedWorklogId=574422&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-574422
]
ASF GitHub Bot logged work on BEAM-11747:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Mar/21 21:14
Start Date: 30/Mar/21 21:14
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #14241:
URL: https://github.com/apache/beam/pull/14241#discussion_r604436080
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
##########
@@ -174,28 +174,39 @@ static boolean hasOnlyJavaUdfInProjects(RelOptRuleCall x)
{
} else if (rexNode instanceof RexLiteral) {
SqlTypeName typeName = ((RexLiteral) rexNode).getTypeName();
switch (typeName) {
- case NULL:
+ case DOUBLE:
case BOOLEAN:
- case CHAR:
- case BINARY:
+ case VARCHAR:
+ case VARBINARY:
case DECIMAL:
+ case TIME:
+ case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
+ case TIMESTAMP:
+ case ARRAY:
Review comment:
done
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
##########
@@ -174,28 +174,39 @@ static boolean hasOnlyJavaUdfInProjects(RelOptRuleCall x)
{
} else if (rexNode instanceof RexLiteral) {
SqlTypeName typeName = ((RexLiteral) rexNode).getTypeName();
switch (typeName) {
- case NULL:
+ case DOUBLE:
case BOOLEAN:
- case CHAR:
- case BINARY:
+ case VARCHAR:
+ case VARBINARY:
case DECIMAL:
+ case TIME:
+ case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
+ case TIMESTAMP:
+ case ARRAY:
+ case ROW:
break;
+ case BIGINT: // BEAM-11989
+ case DATE: // BEAM-11990
default:
- // Reject unsupported literals
return false;
}
} else if (rexNode instanceof RexInputRef) {
SqlTypeName typeName = ((RexInputRef)
rexNode).getType().getSqlTypeName();
switch (typeName) {
- case BIGINT:
case DOUBLE:
case BOOLEAN:
case VARCHAR:
case VARBINARY:
case DECIMAL:
+ case TIME:
+ case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
+ case TIMESTAMP:
+ case ARRAY:
Review comment:
done
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
##########
@@ -174,28 +174,39 @@ static boolean hasOnlyJavaUdfInProjects(RelOptRuleCall x)
{
} else if (rexNode instanceof RexLiteral) {
SqlTypeName typeName = ((RexLiteral) rexNode).getTypeName();
switch (typeName) {
- case NULL:
+ case DOUBLE:
case BOOLEAN:
- case CHAR:
- case BINARY:
+ case VARCHAR:
+ case VARBINARY:
case DECIMAL:
+ case TIME:
+ case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
+ case TIMESTAMP:
+ case ARRAY:
+ case ROW:
break;
+ case BIGINT: // BEAM-11989
+ case DATE: // BEAM-11990
default:
- // Reject unsupported literals
return false;
}
} else if (rexNode instanceof RexInputRef) {
SqlTypeName typeName = ((RexInputRef)
rexNode).getType().getSqlTypeName();
switch (typeName) {
- case BIGINT:
case DOUBLE:
case BOOLEAN:
case VARCHAR:
case VARBINARY:
case DECIMAL:
+ case TIME:
+ case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
+ case TIMESTAMP:
+ case ARRAY:
+ case ROW:
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 574422)
Time Spent: 13h 40m (was: 13.5h)
> Reject the mixed Java UDF and ZetaSQL builtin operators cases
> --------------------------------------------------------------
>
> Key: BEAM-11747
> URL: https://issues.apache.org/jira/browse/BEAM-11747
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql-zetasql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: P2
> Fix For: 2.29.0
>
> Time Spent: 13h 40m
> Remaining Estimate: 0h
>
> Before we have Calc splitting implemented, we can reject the mixed Java UDF
> and ZetaSQL builtin operators cases to maintain the correctness of a query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
