[
https://issues.apache.org/jira/browse/BEAM-9185?focusedWorklogId=574954&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-574954
]
ASF GitHub Bot logged work on BEAM-9185:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/21 16:18
Start Date: 31/Mar/21 16:18
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #14325:
URL: https://github.com/apache/beam/pull/14325#discussion_r605036910
##########
File path: release/src/main/scripts/download_github_actions_artifacts.py
##########
@@ -254,18 +256,27 @@ def prepare_directory(artifacts_dir):
os.makedirs(artifacts_dir)
-def fetch_github_artifacts(run_id, repo_url, artifacts_dir, github_token):
+def filter_artifacts(artifacts, rc_number):
+ def filter_source(artifact_name):
+ if rc_number:
+ return artifact_name.startswith("source_zip_rc{}".format(rc_number))
Review comment:
nit: you can also use f-string: f"source_zip_rc{rc_number}"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 574954)
Time Spent: 8h 20m (was: 8h 10m)
> Publish pre-release python artifacts (RCs) to PyPI
> --------------------------------------------------
>
> Key: BEAM-9185
> URL: https://issues.apache.org/jira/browse/BEAM-9185
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Ahmet Altay
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> This was discussed in the mailing list and there was consensus [1].
> Remaining part for pypi would be updating the release process such as:
> * New RC versioned artifacts are generated along with actual non-RC
> versioned artifacts.
> * RC versioned artifacts are published to pypi.
> [1]
> [https://lists.apache.org/thread.html/f071f8ab9f115636b9e6a6cabcfccbe2bb980d4394fe5581c59a4db6%40%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
