[
https://issues.apache.org/jira/browse/BEAM-5731?focusedWorklogId=199200&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-199200
]
ASF GitHub Bot logged work on BEAM-5731:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Feb/19 12:26
Start Date: 15/Feb/19 12:26
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #7842: [BEAM-5731]
Only accept key operator in Python 3.
URL: https://github.com/apache/beam/pull/7842#discussion_r257214912
##########
File path: sdks/python/apache_beam/transforms/ptransform_test.py
##########
@@ -1875,7 +1875,7 @@ def test_per_key_pipeline_checking_violated(self):
(self.p
| beam.Create(range(100)).with_output_types(int)
| 'Num + 1' >> beam.Map(lambda x: x + 1).with_output_types(int)
- | 'TopMod' >> combine.Top.PerKey(1, lambda a, b: a < b))
Review comment:
The choice of compare function here does not influence the type inference
(which is the point of this test). Incidentally, these were also the default
(natural ordering) so entirely redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 199200)
Time Spent: 50m (was: 40m)
> Disable compare parameter in Top.Of() combiner when executing in Python 3.
> --------------------------------------------------------------------------
>
> Key: BEAM-5731
> URL: https://issues.apache.org/jira/browse/BEAM-5731
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Robert Bradshaw
> Priority: Minor
> Labels: triaged
> Fix For: 2.11.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Removing `compare` parameter in Top.Of() will be a more consistent API with
> `sorted()` function in Python 3. We should also evaluate whether similar
> changes would be reasonable in other places in Beam SDK.
> See also: https://github.com/apache/beam/pull/6570#issuecomment-429176130.
> cc [~altay] [~juta] [~robertwb]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
