[
https://issues.apache.org/jira/browse/BEAM-11213?focusedWorklogId=576183&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-576183
]
ASF GitHub Bot logged work on BEAM-11213:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/21 17:07
Start Date: 02/Apr/21 17:07
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #14409:
URL: https://github.com/apache/beam/pull/14409#discussion_r606329603
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/SparkRunner.java
##########
@@ -246,17 +258,28 @@ public SparkPipelineResult run(final Pipeline pipeline) {
result = new SparkPipelineResult.BatchMode(startPipeline, jsc);
}
- if (mOptions.getEnableSparkMetricSinks()) {
- registerMetricsSource(mOptions.getAppName());
+ if (pipelineOptions.getEnableSparkMetricSinks()) {
+ registerMetricsSource(pipelineOptions.getAppName());
}
// it would have been better to create MetricsPusher from runner-core but
we need
// runner-specific
// MetricsContainerStepMap
MetricsPusher metricsPusher =
new MetricsPusher(
- MetricsAccumulator.getInstance().value(),
mOptions.as(MetricsOptions.class), result);
+ MetricsAccumulator.getInstance().value(),
+ pipelineOptions.as(MetricsOptions.class),
+ result);
metricsPusher.start();
+
+ if (eventLoggingListener != null && jsc != null) {
Review comment:
I'm curious how `jsc` could be null here?
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/SparkRunner.java
##########
@@ -97,7 +102,7 @@
private static final Logger LOG = LoggerFactory.getLogger(SparkRunner.class);
/** Options used in this pipeline runner. */
- private final SparkPipelineOptions mOptions;
+ private final SparkPipelineOptions pipelineOptions;
Review comment:
+1 😄
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/SparkPipelineOptions.java
##########
@@ -34,18 +34,6 @@
*/
public interface SparkPipelineOptions extends SparkCommonPipelineOptions {
- @Description("Set it to true if event logs should be saved to Spark History
Server directory")
Review comment:
Makes sense. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 576183)
Time Spent: 13h 20m (was: 13h 10m)
> Beam metrics should be displayed in Spark UI
> --------------------------------------------
>
> Key: BEAM-11213
> URL: https://issues.apache.org/jira/browse/BEAM-11213
> Project: Beam
> Issue Type: Wish
> Components: runner-spark
> Reporter: Kyle Weaver
> Assignee: Tomasz Szerszen
> Priority: P2
> Labels: portability-spark
> Fix For: 2.29.0
>
> Time Spent: 13h 20m
> Remaining Estimate: 0h
>
> All Beam metrics are visible in the Spark UI in a single accumulator value
> (in the "Accumulators" tab), which is a large, hard-to-read blob. Originally,
> this blob was rendered in a bespoke format
> (https://github.com/apache/beam/blob/ead80b469ffeeddcd8e9e5c8dc462eec0b0ffc6b/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricQueryResults.java#L63-L72).
> I changed the format to JSON so it could be easily deserialized (BEAM-9600).
> But then an issue was filed (BEAM-10294) reporting that the new JSON format
> was harder to read than the original bespoke format. The temporary fix was to
> revert to the bespoke format in Spark, while allowing Flink to continue to
> use JSON. However, if Beam metrics are only visible as an accumulator, then
> they are also unreadable because the payloads are in binary form (BEAM-10719).
> Having metrics visible in Spark's "Metrics" tab would A) make metrics easier
> to read (even compared to the bespoke accumulator string format), and closer
> to what users of Beamless Spark expect, and B) free us to use the accumulator
> however we wish for Beam internal purposes, without worrying about
> readability.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
