[
https://issues.apache.org/jira/browse/BEAM-9514?focusedWorklogId=576355&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-576355
]
ASF GitHub Bot logged work on BEAM-9514:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/21 23:33
Start Date: 02/Apr/21 23:33
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #14392:
URL: https://github.com/apache/beam/pull/14392#issuecomment-812754420
I ran compliance tests on this, and some aggregate function tests are
failing. For example, one such test expects an error. It was listed as
`ALLOW_ERROR` before, and was giving this error:
```
java.lang.AssertionError: type mismatch:
aggCall type:
BIGINT NOT NULL
inferred type:
BIGINT
```
But now it does not throw any error, and instead returns a result, which is
incorrect.
So in summary, this PR fixes one problem, which reveals several other
unrelated problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 576355)
Time Spent: 1h (was: 50m)
> AssertionError type mismatch from AggregateScanConverter
> --------------------------------------------------------
>
> Key: BEAM-9514
> URL: https://issues.apache.org/jira/browse/BEAM-9514
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql-zetasql
> Reporter: Andrew Pilloud
> Priority: P3
> Labels: zetasql-compliance
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Six failures in shard 31
> {code}
> at
> org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.util.Litmus$1.fail(Litmus.java:31)
> at
> org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.plan.RelOptUtil.equal(RelOptUtil.java:1984)
> at
> org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.plan.volcano.RelSubset.add(RelSubset.java:284)
> at
> org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.plan.volcano.RelSet.add(RelSet.java:148)
> at
> org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.plan.volcano.VolcanoPlanner.addRelToSet(VolcanoPlanner.java:1806)
> at
> org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.plan.volcano.VolcanoPlanner.reregister(VolcanoPlanner.java:1480)
> at
> org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.plan.volcano.RelSet.mergeWith(RelSet.java:331)
> at
> org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.plan.volcano.VolcanoPlanner.merge(VolcanoPlanner.java:1571)
> at
> org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.plan.volcano.VolcanoPlanner.ensureRegistered(VolcanoPlanner.java:863)
> at
> org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.plan.volcano.VolcanoPlanner.ensureRegistered(VolcanoPlanner.java:1927)
> at
> org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.plan.volcano.VolcanoRuleCall.transformTo(VolcanoRuleCall.java:129)
> at
> org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.plan.RelOptRuleCall.transformTo(RelOptRuleCall.java:236)
> at
> org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.rel.rules.AggregateRemoveRule.onMatch(AggregateRemoveRule.java:126)
> at
> org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.plan.volcano.VolcanoRuleCall.onMatch(VolcanoRuleCall.java:208)
> at
> org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.plan.volcano.VolcanoPlanner.findBestExp(VolcanoPlanner.java:631)
> at
> org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.tools.Programs$RuleSetProgram.run(Programs.java:328)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLPlannerImpl.transform(ZetaSQLPlannerImpl.java:180)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLQueryPlanner.convertToBeamRelInternal(ZetaSQLQueryPlanner.java:150)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLQueryPlanner.convertToBeamRel(ZetaSQLQueryPlanner.java:115)
> at
> cloud.dataflow.sql.ExecuteQueryServiceServer$SqlComplianceServiceImpl.executeQuery(ExecuteQueryServiceServer.java:242)
> at
> com.google.zetasql.testing.SqlComplianceServiceGrpc$MethodHandlers.invoke(SqlComplianceServiceGrpc.java:423)
> at
> com.google.zetasql.io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:171)
> at
> com.google.zetasql.io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:283)
> at
> com.google.zetasql.io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:711)
> at
> com.google.zetasql.io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
> at
> com.google.zetasql.io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> 1:
> {code}
> Apr 01, 2020 11:48:56 AM
> cloud.dataflow.sql.ExecuteQueryServiceServer$SqlComplianceServiceImpl
> executeQuery
> INFO: Processing Sql statement: select sum(distinct_4) from TableDistincts
> group by distinct_2
> having false
> Apr 01, 2020 11:48:57 AM
> cloud.dataflow.sql.ExecuteQueryServiceServer$SqlComplianceServiceImpl
> executeQuery
> SEVERE: !!!! Type mismatch:
> rowtype of new rel:
> RecordType(BIGINT distinct_2, BIGINT $col1) NOT NULL
> rowtype of set:
> RecordType(BIGINT distinct_2, BIGINT NOT NULL $col1) NOT NULL
> java.lang.AssertionError: Type mismatch:
> rowtype of new rel:
> RecordType(BIGINT distinct_2, BIGINT $col1) NOT NULL
> rowtype of set:
> RecordType(BIGINT distinct_2, BIGINT NOT NULL $col1) NOT NULL
> at org.apache.beam.vendor.calcite.v1_20_0.org.apache.cal
> {code}
> 2:
> {code}
> INFO: Processing Sql statement: select sum(distinct_4) from TableDistincts
> group by distinct_2
> having sum(distinct_4) > 14 and false
> Apr 01, 2020 11:48:58 AM
> cloud.dataflow.sql.ExecuteQueryServiceServer$SqlComplianceServiceImpl
> executeQuery
> SEVERE: !!!! Type mismatch:
> rowtype of new rel:
> RecordType(BIGINT distinct_2, BIGINT $col1, BIGINT $agg2) NOT NULL
> rowtype of set:
> RecordType(BIGINT distinct_2, BIGINT NOT NULL $col1, BIGINT NOT NULL $agg2)
> NOT NULL
> java.lang.AssertionError: Type mismatch:
> rowtype of new rel:
> RecordType(BIGINT distinct_2, BIGINT $col1, BIGINT $agg2) NOT NULL
> rowtype of set:
> RecordType(BIGINT distinct_2, BIGINT NOT NULL $col1, BIGINT NOT NULL $agg2)
> NOT NULL
> {code}
> 3:
> {code}
> Apr 01, 2020 11:48:58 AM
> cloud.dataflow.sql.ExecuteQueryServiceServer$SqlComplianceServiceImpl
> executeQuery
> INFO: Processing Sql statement: select sum(distinct_4) from TableDistincts
> group by distinct_2
> having sum(distinct_4) > 14 and null
> Apr 01, 2020 11:48:58 AM
> cloud.dataflow.sql.ExecuteQueryServiceServer$SqlComplianceServiceImpl
> executeQuery
> SEVERE: !!!! Type mismatch:
> rowtype of new rel:
> RecordType(BIGINT distinct_2, BIGINT $col1, BIGINT $agg2) NOT NULL
> rowtype of set:
> RecordType(BIGINT distinct_2, BIGINT NOT NULL $col1, BIGINT NOT NULL $agg2)
> NOT NULL
> java.lang.AssertionError: Type mismatch:
> rowtype of new rel:
> RecordType(BIGINT distinct_2, BIGINT $col1, BIGINT $agg2) NOT NULL
> rowtype of set:
> RecordType(BIGINT distinct_2, BIGINT NOT NULL $col1, BIGINT NOT NULL $agg2)
> NOT NULL
> {code}
> 4:
> {code}
> Apr 01, 2020 11:49:04 AM
> cloud.dataflow.sql.ExecuteQueryServiceServer$SqlComplianceServiceImpl
> executeQuery
> INFO: Processing Sql statement: select sum(distinct_4) from
> TableDistinctsWithNulls
> group by distinct_2
> having false
> Apr 01, 2020 11:49:04 AM
> cloud.dataflow.sql.ExecuteQueryServiceServer$SqlComplianceServiceImpl
> executeQuery
> SEVERE: !!!! Type mismatch:
> rowtype of new rel:
> RecordType(BIGINT distinct_2, BIGINT $col1) NOT NULL
> rowtype of set:
> RecordType(BIGINT distinct_2, BIGINT NOT NULL $col1) NOT NULL
> java.lang.AssertionError: Type mismatch:
> rowtype of new rel:
> RecordType(BIGINT distinct_2, BIGINT $col1) NOT NULL
> rowtype of set:
> RecordType(BIGINT distinct_2, BIGINT NOT NULL $col1) NOT NULL
> {code}
> 5:
> {code}
> Apr 01, 2020 11:49:04 AM
> cloud.dataflow.sql.ExecuteQueryServiceServer$SqlComplianceServiceImpl
> executeQuery
> INFO: Processing Sql statement: select sum(distinct_4) from
> TableDistinctsWithNulls
> group by distinct_2
> having sum(distinct_4) > 14 and false
> Apr 01, 2020 11:49:05 AM
> cloud.dataflow.sql.ExecuteQueryServiceServer$SqlComplianceServiceImpl
> executeQuery
> SEVERE: !!!! Type mismatch:
> rowtype of new rel:
> RecordType(BIGINT distinct_2, BIGINT $col1, BIGINT $agg2) NOT NULL
> rowtype of set:
> RecordType(BIGINT distinct_2, BIGINT NOT NULL $col1, BIGINT NOT NULL $agg2)
> NOT NULL
> java.lang.AssertionError: Type mismatch:
> rowtype of new rel:
> RecordType(BIGINT distinct_2, BIGINT $col1, BIGINT $agg2) NOT NULL
> rowtype of set:
> RecordType(BIGINT distinct_2, BIGINT NOT NULL $col1, BIGINT NOT NULL $agg2)
> NOT NULL
> {code}
> 6:
> {code}
> Apr 01, 2020 11:49:05 AM
> cloud.dataflow.sql.ExecuteQueryServiceServer$SqlComplianceServiceImpl
> executeQuery
> INFO: Processing Sql statement: select sum(distinct_4) from
> TableDistinctsWithNulls
> group by distinct_2
> having sum(distinct_4) > 14 and null
> Apr 01, 2020 11:49:05 AM
> cloud.dataflow.sql.ExecuteQueryServiceServer$SqlComplianceServiceImpl
> executeQuery
> SEVERE: !!!! Type mismatch:
> rowtype of new rel:
> RecordType(BIGINT distinct_2, BIGINT $col1, BIGINT $agg2) NOT NULL
> rowtype of set:
> RecordType(BIGINT distinct_2, BIGINT NOT NULL $col1, BIGINT NOT NULL $agg2)
> NOT NULL
> java.lang.AssertionError: Type mismatch:
> rowtype of new rel:
> RecordType(BIGINT distinct_2, BIGINT $col1, BIGINT $agg2) NOT NULL
> rowtype of set:
> RecordType(BIGINT distinct_2, BIGINT NOT NULL $col1, BIGINT NOT NULL $agg2)
> NOT NULL
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
