[ 
https://issues.apache.org/jira/browse/BEAM-6676?focusedWorklogId=199378&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-199378
 ]

ASF GitHub Bot logged work on BEAM-6676:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Feb/19 18:55
            Start Date: 15/Feb/19 18:55
    Worklog Time Spent: 10m 
      Work Description: tweise commented on issue #7850: [BEAM-6676] Properly 
assign windows to timer set requests.
URL: https://github.com/apache/beam/pull/7850#issuecomment-464159657
 
 
   Thanks! This resolves the issue but I think we should improve test coverage. 
How about augmenting test_pardo_state_timers in 
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/portability/fn_api_runner_test.py#L313
 to use a fixed window (other state and timer tests all use GlobalWindow)
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 199378)
    Time Spent: 20m  (was: 10m)

> Python timers only working with GlobalWindow
> --------------------------------------------
>
>                 Key: BEAM-6676
>                 URL: https://issues.apache.org/jira/browse/BEAM-6676
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-harness
>    Affects Versions: 2.10.0
>            Reporter: Thomas Weise
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Setting a timer with the Py SDK fails with fixed window (portable runner).
> Test case attached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to