[
https://issues.apache.org/jira/browse/BEAM-6672?focusedWorklogId=199391&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-199391
]
ASF GitHub Bot logged work on BEAM-6672:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Feb/19 19:20
Start Date: 15/Feb/19 19:20
Worklog Time Spent: 10m
Work Description: Ardagan commented on pull request #7847: [BEAM-6672]
Add the StateRequestHandlerImpl and test
URL: https://github.com/apache/beam/pull/7847#discussion_r257359895
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/StateRequestHandlerImpl.java
##########
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.dataflow.worker.fn.control;
+
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.CompletionStage;
+import java.util.concurrent.ConcurrentHashMap;
+import org.apache.beam.model.fnexecution.v1.BeamFnApi;
+import org.apache.beam.runners.core.StateNamespaces;
+import org.apache.beam.runners.core.StateTags;
+import org.apache.beam.runners.dataflow.worker.ByteStringCoder;
+import org.apache.beam.runners.dataflow.worker.DataflowExecutionContext;
+import org.apache.beam.runners.fnexecution.state.StateRequestHandler;
+import org.apache.beam.sdk.state.BagState;
+import org.apache.beam.sdk.transforms.windowing.GlobalWindow;
+import org.apache.beam.vendor.grpc.v1p13p1.com.google.protobuf.ByteString;
+
+/**
+ * Class that handles serving UserState.
+ *
+ * <p>This class is responsible for multiplexing {@link
+ * org.apache.beam.model.fnexecution.v1.BeamFnApi.StateRequest}s and serving
{@link
+ * org.apache.beam.model.fnexecution.v1.BeamFnApi.StateResponse}s. This class
is thread safe.
+ * Internally, this class uses the {@link
org.apache.beam.runners.core.InMemoryStateInternals} for
+ * persistence only during a bundle's lifetime. All state will automatically
be cleared after the
+ * bundle is finished. This class is meant to be used with the {@link
+ * org.apache.beam.runners.fnexecution.control.StageBundleFactory}.
+ */
+public class StateRequestHandlerImpl implements StateRequestHandler {
+
+ private DataflowExecutionContext.DataflowStepContext ctxt;
+ private ConcurrentHashMap<BeamFnApi.StateKey, BagState<ByteString>>
userStateData;
+
+ public StateRequestHandlerImpl(DataflowExecutionContext.DataflowStepContext
ctxt) {
+ this.ctxt = ctxt;
+ this.userStateData = new ConcurrentHashMap<>();
+ }
+
+ /**
+ * @param request A StateRequest containing instructions for the handler.
+ * @return Returns a future containing the response as a StateResponse
builder.
+ * @throws UnsupportedOperationException This only handles BAG_USER_STATE
{@link
+ * BeamFnApi.StateKey}s.
+ */
+ @Override
+ public CompletionStage<BeamFnApi.StateResponse.Builder>
handle(BeamFnApi.StateRequest request)
+ throws UnsupportedOperationException {
+
+ // TODO(BEAM-6672): Handle MultiMap state keys.
+ switch (request.getStateKey().getTypeCase()) {
+ case BAG_USER_STATE:
+ return handleBagUserState(request);
+ default:
+ throw new UnsupportedOperationException(
+ String.format(
+ "Dataflow does not handle StateRequests of type %s",
+ request.getStateKey().getTypeCase()));
+ }
+ }
+
+ private CompletionStage<BeamFnApi.StateResponse.Builder> handleBagUserState(
+ BeamFnApi.StateRequest request) {
+ BeamFnApi.StateKey.BagUserState bagUserStateKey =
request.getStateKey().getBagUserState();
+ // TODO(BEAM-6672): We should not be required to hold onto a pointer to
the bag states for the
+ // user. InMemoryStateInternals assumes that the Java garbage collector
does the clean-up work
+ // but instead StateInternals should hold its own references and write out
any data and
+ // clear references when the MapTask within Dataflow completes like how
WindmillStateInternals
+ // works.
+ BagState<ByteString> state =
+ userStateData.computeIfAbsent(
+ request.getStateKey(),
+ unusedKey ->
+ ctxt.stateInternals()
+ .state(
+ // TODO(BEAM-6672): Once we have access to the
ParDoPayload, use its
+ // windowing strategy to decode the window for the
well known window types.
+ // Longer term we need to swap to use the encoded
version and not rely on
+ // needing to decode the entire window.
+ StateNamespaces.window(GlobalWindow.Coder.INSTANCE,
GlobalWindow.INSTANCE),
+ StateTags.bag(bagUserStateKey.getUserStateId(),
ByteStringCoder.of())));
+
+ CompletionStage<BeamFnApi.StateResponse.Builder> response;
+ switch (request.getRequestCase()) {
+ case GET:
+ response =
+ CompletableFuture.completedFuture(
+ BeamFnApi.StateResponse.newBuilder()
+
.setGet(BeamFnApi.StateGetResponse.newBuilder().setData(concat(state.read()))));
+ break;
+ case APPEND:
+ state.add(request.getAppend().getData());
Review comment:
I believe this is a non-thread safe call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 199391)
Time Spent: 3h (was: 2h 50m)
> Make bundle execution with ExecutableStage support user states
> --------------------------------------------------------------
>
> Key: BEAM-6672
> URL: https://issues.apache.org/jira/browse/BEAM-6672
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
