[
https://issues.apache.org/jira/browse/BEAM-6652?focusedWorklogId=199458&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-199458
]
ASF GitHub Bot logged work on BEAM-6652:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Feb/19 21:56
Start Date: 15/Feb/19 21:56
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #7857: [BEAM-6652]
Reinstate Maps- Validate json is deterministic.
URL: https://github.com/apache/beam/pull/7857
I determined that the Go Standard Library JSON encoder handles maps
deterministically. This PR:
* extends the tests on the default encoder (JSON) to validate deterministic
map encoding.
* Re-allows maps as a valid PCollection type.
* Sets Protobuf encoding to be deterministic.
Still to do for [BEAM-6652] is to extend ptest with a way for users to test
registered coders since most of this scaffolding would be common for all
coders. The "default" JSON coder can't use this directly since it would
introduce a beam -> ptest -> beam import cycle.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
See [.test-infra/jenkins/README](../.test-infra/jenkins/README.md) for
trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 199458)
Time Spent: 40m (was: 0.5h)
> Handle map encoding better.
> ---------------------------
>
> Key: BEAM-6652
> URL: https://issues.apache.org/jira/browse/BEAM-6652
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Maps are a dangerous type to have as part of key values, and the Go SDK
> currently doesn't handle them very well. Until we have a default coder that
> assures that map encodings are canonical, it's better that we restrict their
> usage within the SDK.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
