[
https://issues.apache.org/jira/browse/BEAM-12096?focusedWorklogId=577253&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-577253
]
ASF GitHub Bot logged work on BEAM-12096:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Apr/21 01:56
Start Date: 06/Apr/21 01:56
Worklog Time Spent: 10m
Work Description: KevinGG commented on a change in pull request #14437:
URL: https://github.com/apache/beam/pull/14437#discussion_r607434885
##########
File path: sdks/python/apache_beam/runners/interactive/utils.py
##########
@@ -205,7 +207,9 @@ def __enter__(self):
else:
display(self._enter_text)
except ImportError:
- pass # NOOP when dependencies are not available.
+ _LOGGER.warning(
Review comment:
Added the log of ImportError.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 577253)
Time Spent: 1.5h (was: 1h 20m)
> Flake: test_progress_in_HTML_JS_when_in_notebook
> ------------------------------------------------
>
> Key: BEAM-12096
> URL: https://issues.apache.org/jira/browse/BEAM-12096
> Project: Beam
> Issue Type: Bug
> Components: test-failures
> Reporter: Kyle Weaver
> Assignee: Ning Kang
> Priority: P1
> Labels: flaky-test
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> *
> https://ci-beam.apache.org/job/beam_PreCommit_Python_Commit/18008/testReport/junit/apache_beam.runners.interactive.utils_test/ProgressIndicatorTest/test_progress_in_HTML_JS_when_in_notebook/
> self = <apache_beam.runners.interactive.utils_test.ProgressIndicatorTest
> testMethod=test_progress_in_HTML_JS_when_in_notebook> def
> test_progress_in_HTML_JS_when_in_notebook(self):
> ie.current_env()._is_in_notebook = True pi_path =
> 'apache_beam.runners.interactive.utils.ProgressIndicator' with
> patch('IPython.core.display.HTML') as mocked_html, \
> patch('IPython.core.display.Javascript') as mocked_javascript, \
> patch(pi_path + '.spinner_template') as enter_template, \ patch(pi_path +
> '.spinner_removal_template') as exit_template:
> enter_template.format.return_value = 'enter'
> exit_template.format.return_value = 'exit' @utils.progress_indicated def
> progress_indicated_dummy(): mocked_html.assert_any_call('enter') >
> progress_indicated_dummy() apache_beam/runners/interactive/utils_test.py:217:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _ apache_beam/runners/interactive/utils.py:235: in
> run_within_progress_indicator return func(*args, **kwargs)
> apache_beam/runners/interactive/utils_test.py:215: in
> progress_indicated_dummy mocked_html.assert_any_call('enter') _ _ _ _ _ _ _ _
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self =
> <MagicMock name='HTML' id='140195651256392'>, args = ('enter',) kwargs = {},
> expected = (('enter',), {}) actual = [call('\n <link rel="stylesheet" href="
> [https://stackpath.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min...";|https://stackpath.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min...]
> >You have limited Interactive Beam features since your ipython kernel is not
> >connected any notebook frontend.</div>')] cause = None, expected_string =
> >"HTML('enter')" def assert_any_call(self, *args, **kwargs): """assert the
> >mock has been called with the specified arguments. The assert passes if the
> >mock has *ever* been called, unlike `assert_called_with` and
> >`assert_called_once_with` that only pass if the call is the most recent
> >one.""" expected = self._call_matcher((args, kwargs)) actual =
> >[self._call_matcher(c) for c in self.call_args_list] if expected not in
> >actual: cause = expected if isinstance(expected, Exception) else None
> >expected_string = self._format_mock_call_signature(args, kwargs) raise
> >AssertionError( '%s call not found' % expected_string > ) from cause E
> >AssertionError: HTML('enter') call not found
> >/usr/lib/python3.7/unittest/mock.py:891: AssertionError
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
