[
https://issues.apache.org/jira/browse/BEAM-5644?focusedWorklogId=199518&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-199518
]
ASF GitHub Bot logged work on BEAM-5644:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Feb/19 23:43
Start Date: 15/Feb/19 23:43
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7745:
[BEAM-5644] make Planner configurable
URL: https://github.com/apache/beam/pull/7745#discussion_r257425940
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/BeamSqlEnv.java
##########
@@ -73,109 +80,182 @@ public static BeamSqlEnv inMemory(TableProvider...
tableProviders) {
return withTableProvider(inMemoryMetaStore);
}
- private void registerBuiltinUdf(Map<String, List<Method>> methods) {
- for (Map.Entry<String, List<Method>> entry : methods.entrySet()) {
- for (Method method : entry.getValue()) {
- connection.getCurrentSchemaPlus().add(entry.getKey(),
UdfImpl.create(method));
- }
- }
+ public BeamRelNode parseQuery(String query) throws ParseException {
Review comment:
I think that it would make sense to refactor (maybe later) so that the
pluggable part is `String` -> `RelNode` which might allow plugging things like
Calcite babel and then separately `RelNode` -> `BeamRelNode` would be the
physical planner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 199518)
> make Planner configurable
> --------------------------
>
> Key: BEAM-5644
> URL: https://issues.apache.org/jira/browse/BEAM-5644
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Labels: triaged
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
> We can make planner configurable here:
> [BeamQueryPlanner.java#L145|https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/BeamQueryPlanner.java#L145]
>
> By doing so, we can have different planner implementation to support
> different SQL dialect.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
