[
https://issues.apache.org/jira/browse/BEAM-12040?focusedWorklogId=578642&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-578642
]
ASF GitHub Bot logged work on BEAM-12040:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Apr/21 20:16
Start Date: 07/Apr/21 20:16
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#14450:
URL: https://github.com/apache/beam/pull/14450#discussion_r609039594
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java
##########
@@ -349,15 +326,14 @@ public void validate(PipelineOptions options) {
getWindowedWrites(),
"Must use windowed writes when applying %s to an unbounded
PCollection",
WriteFiles.class.getSimpleName());
- // The reason for this is https://issues.apache.org/jira/browse/BEAM-1438
- // and similar behavior in other runners. Runners can choose to ignore
this check and perform
- // runner determined sharding for unbounded data by overriding the option
- // `withRunnerDeterminedShardingUnboundedInternal`.
- if (!getWithRunnerDeterminedShardingUnbounded()) {
+ // Sharding used to be required due to
https://issues.apache.org/jira/browse/BEAM-1438 and
+ // similar behavior in other runners. Some runners may support runner
determined sharding now.
+ // Check merging window here due to
https://issues.apache.org/jira/browse/BEAM-12040.
+ if (input.getWindowingStrategy().needsMerge()) {
Review comment:
I think it's a regression since failing early (for new pipelines) is
much more desired over failing at runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 578642)
Time Spent: 2h (was: 1h 50m)
> WriteFiles withRunnerDeterminedShardingUnbounded doesn't work with session
> windows
> ----------------------------------------------------------------------------------
>
> Key: BEAM-12040
> URL: https://issues.apache.org/jira/browse/BEAM-12040
> Project: Beam
> Issue Type: Improvement
> Components: io-java-files
> Reporter: Siyuan Chen
> Priority: P2
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Currently the implementation of `withRunnerDeterminedShardingUnbounded` uses
> a stateful DoFn to achieve the grouping and batching of the input elements,
> which doesn't support session windows. One possible way is to add another GBK
> prior to the stateful DoFn to first get session windows merged and reify the
> window before invoking the sateful DoFn.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
