[
https://issues.apache.org/jira/browse/BEAM-12127?focusedWorklogId=579370&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-579370
]
ASF GitHub Bot logged work on BEAM-12127:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/21 17:21
Start Date: 08/Apr/21 17:21
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #14473:
URL: https://github.com/apache/beam/pull/14473#issuecomment-816000692
@kileys also recently did some work in/around the
`PCollectionConsumerRegistry` and counters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 579370)
Time Spent: 0.5h (was: 20m)
> Reduce counter overhead in PCollectionConsumerRegistry.accept
> -------------------------------------------------------------
>
> Key: BEAM-12127
> URL: https://issues.apache.org/jira/browse/BEAM-12127
> Project: Beam
> Issue Type: Bug
> Components: java-fn-execution
> Reporter: Sam Whittle
> Assignee: Sam Whittle
> Priority: P2
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> DelegatingCounter.inc shows up as 21% of cpu on nexmark query 2 benchmark
> under PCollectionConsumerRegistry.accept
> 2% is actual counter incrementing, but the majority is the delegation of
> DelegatingCounter which involves looking up thread-local state and then
> getting the counter for the name from the counter container. However in this
> case the counter container is known and can just be bound when constructing
> the counter instaed of using DelegatingCounter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
