[
https://issues.apache.org/jira/browse/BEAM-9547?focusedWorklogId=580135&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-580135
]
ASF GitHub Bot logged work on BEAM-9547:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/21 16:50
Start Date: 09/Apr/21 16:50
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#14361:
URL: https://github.com/apache/beam/pull/14361#discussion_r610773229
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -783,6 +783,33 @@ def nsmallest(self, keep, **kwargs):
preserves_partition_by=partitionings.Arbitrary(),
requires_partition_by=partitionings.Singleton()))
+ @property
+ def is_unique(self):
+ def set_index(s):
+ s = s[:]
+ s.index = s
Review comment:
Thanks thats a good question. I did some local experiments and it looks
like anything _can_ be placed in the index. I added some test cases for other
dtypes (floats and strings) to be sure.
##########
File path: sdks/python/apache_beam/dataframe/frames_test.py
##########
@@ -453,6 +453,13 @@ def test_series_getitem(self):
s.index = s.index.map(float)
self._run_test(lambda s: s[1.5:6], s)
+ def test_series_is_unique(self):
+ s_unique = pd.Series(range(10))
+ s_dupes = pd.Series(i % 4 for i in range(10))
Review comment:
Done, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 580135)
Time Spent: 69h 20m (was: 69h 10m)
> Implement all pandas operations (or raise WontImplementError)
> -------------------------------------------------------------
>
> Key: BEAM-9547
> URL: https://issues.apache.org/jira/browse/BEAM-9547
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Robert Bradshaw
> Priority: P2
> Labels: dataframe-api
> Time Spent: 69h 20m
> Remaining Estimate: 0h
>
> We should have an implementation for every DataFrame, Series, and GroupBy
> method. Everything that's not possible to implement should get a default
> implementation that raises WontImplementError
> See https://github.com/apache/beam/pull/10757#discussion_r389132292
> Progress at the individual operation level is tracked in a
> [spreadsheet|https://docs.google.com/spreadsheets/d/1hHAaJ0n0k2tw465ORs5tfdy4Lg0DnGWIQ53cLjAhel0/edit],
> consider requesting edit access if you'd like to help out.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
