[
https://issues.apache.org/jira/browse/BEAM-11408?focusedWorklogId=580492&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-580492
]
ASF GitHub Bot logged work on BEAM-11408:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Apr/21 05:52
Start Date: 10/Apr/21 05:52
Worklog Time Spent: 10m
Work Description: nehsyc commented on a change in pull request #14499:
URL: https://github.com/apache/beam/pull/14499#discussion_r611001573
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1417,7 +1417,12 @@ def _add_random_shard(element):
value = element[1]
return ((key, random.randint(0, DEFAULT_SHARDS_PER_DESTINATION)), value)
- def _to_hashable_table_ref(table_ref_elem_kv):
+ V = TypeVar('V')
+ TABLE_REF_TYPE = TypeVar('TABLE_REF_TYPE')
Review comment:
Aha. That makes more sense! Corrected.
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1417,7 +1417,12 @@ def _add_random_shard(element):
value = element[1]
return ((key, random.randint(0, DEFAULT_SHARDS_PER_DESTINATION)), value)
- def _to_hashable_table_ref(table_ref_elem_kv):
+ V = TypeVar('V')
+ TABLE_REF_TYPE = TypeVar('TABLE_REF_TYPE')
+
+ def _to_hashable_table_ref(
Review comment:
Good idea. I moved it to bigquery_tools.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 580492)
Time Spent: 17h 10m (was: 17h)
> GCP BigQuery sink (streaming inserts) uses runner determined sharding
> ---------------------------------------------------------------------
>
> Key: BEAM-11408
> URL: https://issues.apache.org/jira/browse/BEAM-11408
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Siyuan Chen
> Assignee: Siyuan Chen
> Priority: P1
> Fix For: 2.28.0
>
> Time Spent: 17h 10m
> Remaining Estimate: 0h
>
> Integrate BigQuery sink with shardable `GroupIntoBatches` (BEAM-10475) to
> allow runner determined dynamic sharding.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
