[ 
https://issues.apache.org/jira/browse/BEAM-11408?focusedWorklogId=580625&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-580625
 ]

ASF GitHub Bot logged work on BEAM-11408:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Apr/21 22:01
            Start Date: 10/Apr/21 22:01
    Worklog Time Spent: 10m 
      Work Description: nehsyc commented on a change in pull request #14499:
URL: https://github.com/apache/beam/pull/14499#discussion_r611098461



##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -69,6 +71,11 @@
 except ImportError:
   pass
 
+try:

Review comment:
       I had to explicitly import this otherwise many tests failed with 
"apache_beam.io.gcp.internal.clients.bigquery has no attribute TableReference" 
- I guess bigquery lib was not available in some environments. The pylint check 
also failed possibly because of this but I haven't figured out what's wrong. 
Any insights?

##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -69,6 +71,11 @@
 except ImportError:
   pass
 
+try:

Review comment:
       I had to explicitly import this otherwise many tests failed with 
"apache_beam.io.gcp.internal.clients.bigquery has no attribute TableReference" 
- I guess bigquery lib was not available in some environments. The pylint check 
also failed possibly because of this but I haven't figured out what's wrong. 
Any insights?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 580625)
    Time Spent: 19h 20m  (was: 19h 10m)

> GCP BigQuery sink (streaming inserts) uses runner determined sharding
> ---------------------------------------------------------------------
>
>                 Key: BEAM-11408
>                 URL: https://issues.apache.org/jira/browse/BEAM-11408
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-gcp
>            Reporter: Siyuan Chen
>            Assignee: Siyuan Chen
>            Priority: P1
>             Fix For: 2.28.0
>
>          Time Spent: 19h 20m
>  Remaining Estimate: 0h
>
> Integrate BigQuery sink with shardable `GroupIntoBatches` (BEAM-10475) to 
> allow runner determined dynamic sharding.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to