[
https://issues.apache.org/jira/browse/BEAM-12136?focusedWorklogId=581457&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581457
]
ASF GitHub Bot logged work on BEAM-12136:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/21 00:25
Start Date: 13/Apr/21 00:25
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #14455:
URL: https://github.com/apache/beam/pull/14455#discussion_r612038793
##########
File path: sdks/python/apache_beam/coders/coder_impl.py
##########
@@ -418,6 +422,12 @@ def encode_to_stream(self, value, stream, nested):
self.fallback_coder_impl.encode_to_stream(value, stream, nested)
def encode_special_deterministic(self, value, stream):
+ if not self.warn_deterministic_fallback:
+ _LOGGER.warning(
+ "Using fallback deterministic coder for type '%s' in '%s'. ",
+ type(value),
+ self.requires_deterministic_step_label)
+ self.warn_deterministic_fallback = True
Review comment:
Nit: A True value sounds like it will warn, which is opposite of the
semantic here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 581457)
Time Spent: 20m (was: 10m)
> Add deterministic coders for common Python types
> ------------------------------------------------
>
> Key: BEAM-12136
> URL: https://issues.apache.org/jira/browse/BEAM-12136
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Udi Meiri
> Priority: P2
> Labels: types
> Time Spent: 20m
> Remaining Estimate: 0h
>
> FastPrimitivesCodeImpl has "fallback" deterministic encoding of certain types
> in encode_special_deterministic. This encoding is not as efficient as a
> type-specific coder (https://github.com/apache/beam/pull/14455).
> This bug is to implement type-specific coders for the types supported in
> encode_special_deterministic. This method will still handle encoding for
> cases in which type information is not available, and the new coders will be
> used where type hints are available.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
