[
https://issues.apache.org/jira/browse/BEAM-11205?focusedWorklogId=583056&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-583056
]
ASF GitHub Bot logged work on BEAM-11205:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Apr/21 00:34
Start Date: 15/Apr/21 00:34
Worklog Time Spent: 10m
Work Description: suztomo commented on a change in pull request #14527:
URL: https://github.com/apache/beam/pull/14527#discussion_r613669141
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImplTest.java
##########
@@ -1056,11 +1082,25 @@ public void testCreateTableRetry() throws IOException {
Table ret =
services.tryCreateTable(
testTable, new RetryBoundedBackOff(3, BackOff.ZERO_BACKOFF),
Sleeper.DEFAULT);
- assertEquals(testTable, ret);
+ // This assertion fails
+ // expected:<GenericData{classInfo=[clustering, creationTime, description,
+ // encryptionConfiguration, etag, expirationTime,
externalDataConfiguration, friendlyName, id,
+ // kind, labels, lastModifiedTime, location, materializedView, model,
numBytes,
+ // numLongTermBytes, numPhysicalBytes, numRows, rangePartitioning,
requirePartitionFilter,
+ // schema, selfLink, snapshotDefinition, streamingBuffer, tableReference,
timePartitioning,
+ // type, view], {tableReference=GenericData{classInfo=[datasetId,
projectId, tableId],
+ // {datasetId=dataset, projectId=project, tableId=table}}}}> but
+ //
was:<{"error":{"code":403,"errors":[{"domain":"global","reason":"rateLimitExceeded"}],"message":"rateLimitExceeded"}}>
+ // assertEquals(testTable, ret);
verify(response, times(2)).getStatusCode();
- verify(response, times(2)).getContent();
- verify(response, times(2)).getContentType();
- verifyNotNull(ret.getTableReference());
+ verify(response, times(1)).getContent();
+ verify(response, times(1)).getContentType();
+
+ // This was null
+ // verifyNotNull(ret.getTableReference());
+
+ // Google-http-client 1.39.1 does not read the content of response with
error status code. How
+ // can we ensure our library shows proper error messages to users?
expectedLogs.verifyInfo(
"Quota limit reached when creating table project:dataset.table, "
Review comment:
Before this PR, it created `GoogleJsonResponseException`. Here is the
stacktrace.
<img width="1332" alt="Screen Shot 2021-04-14 at 20 33 35"
src="https://user-images.githubusercontent.com/28604/114797265-c86dea80-9d60-11eb-8f9a-6993d085b0f3.png";>
`ApiErrorExtractor` was reading the GoogleJsonResponseException that holds
the content:
```
{
"code" : 403,
"errors" : [ {
"domain" : "global",
"reason" : "rateLimitExceeded"
} ],
"message" : "rateLimitExceeded"
}
```
In tryCreateTable
([code](https://github.com/apache/beam/blob/4b7b74673b647c8d964b4877a8d66d47096acce4/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java#L626)),
`extractor.rateLimited(e)` determines the cause of the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 583056)
Time Spent: 13h 40m (was: 13.5h)
> Beam Dependency Update Request: com.google.cloud:libraries-bom
> --------------------------------------------------------------
>
> Key: BEAM-11205
> URL: https://issues.apache.org/jira/browse/BEAM-11205
> Project: Beam
> Issue Type: Sub-task
> Components: dependencies
> Reporter: Beam JIRA Bot
> Priority: P3
> Time Spent: 13h 40m
> Remaining Estimate: 0h
>
> ------------------------- 2020-11-09 12:16:08.172595
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 15.0.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-11-16 12:18:49.798793
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 15.1.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-11-23 12:19:51.199039
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.1.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-11-30 12:17:29.500873
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.1.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-12-07 12:21:08.748853
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.1.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-12-14 12:29:04.542548
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.1.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-12-21 12:19:36.603441
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.2.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-12-28 12:18:16.249769
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.2.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-01-04 12:18:36.130621
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.2.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-01-11 12:19:38.435168
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.2.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-01-18 12:39:57.569136
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.3.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-01-25 12:21:43.434396
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.3.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-02-01 12:21:46.860882
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.3.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-02-08 12:25:15.112066
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.3.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-02-15 12:22:57.783575
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 13.2.0. The latest version is 16.4.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-01 12:21:19.025373
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 16.3.0. The latest version is 18.0.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-08 12:23:06.962620
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 16.3.0. The latest version is 19.0.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-15 12:24:46.684593
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 16.3.0. The latest version is 19.0.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-22 12:22:22.770376
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 16.3.0. The latest version is 19.2.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-29 12:22:10.157690
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 16.3.0. The latest version is 19.2.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-04-05 12:23:32.502855
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 16.3.0. The latest version is 19.2.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-04-12 12:24:46.306174
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:libraries-bom.
> The current version is 16.3.0. The latest version is 19.2.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
![https://user-images.githubusercontent.com/28604/114797265-c86dea80-9d60-11eb-8f9a-6993d085b0f3.png"](https://user-images.githubusercontent.com/28604/114797265-c86dea80-9d60-11eb-8f9a-6993d085b0f3.png"){kind=link}