[ 
https://issues.apache.org/jira/browse/BEAM-12150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322012#comment-17322012
 ] 

Alexey Romanenko commented on BEAM-12150:
-----------------------------------------

{quote}Is Docker necessary for running this test? That is, could the test be 
written without using Docker?{quote}

Yes, Docker is required to run this test. I'd transfer this question to 
[~gleb], who mostly developed {{ClickHouseIO}} and tests for it for more 
concrete answer.

{quote}If not, there should probably be some sort of assume to check whether 
the test is running inside docker and skip it rather than failing.{quote}

It could be an option since this one is not only the test that requires Docker 
and we probably should annotate such tests with specific {{NeedsDocker}} 
annotation and skip them. The question is how to detect that the tests are 
running from Docker and how to let a user that not all tests are passed. 

I encourage to discuss it on [email protected] to attract more opinions.

> Clickhouse test failures
> ------------------------
>
>                 Key: BEAM-12150
>                 URL: https://issues.apache.org/jira/browse/BEAM-12150
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-clickhouse
>            Reporter: Elliotte Rusty Harold
>            Priority: P2
>
> This is using the Docker dev environment with zero changes from head. I.e. a 
> clean checkout.
>  
> $ ./gradlew -p sdks/java/io/clickhouse check
> Configuration on demand is an incubating feature.
> > Task :sdks:java:io:clickhouse:test
>  
> org.apache.beam.sdk.io.clickhouse.AtomicInsertTest > classMethod FAILED
>  java.lang.IllegalStateException at DockerClientProviderStrategy.java:215
> org.apache.beam.sdk.io.clickhouse.AtomicInsertTest > classMethod FAILED
>  java.lang.NullPointerException at BaseClickHouseTest.java:134
> org.apache.beam.sdk.io.clickhouse.ClickHouseIOTest > classMethod FAILED
>  java.lang.IllegalStateException at DockerClientProviderStrategy.java:109
> org.apache.beam.sdk.io.clickhouse.ClickHouseIOTest > classMethod FAILED
>  java.lang.NullPointerException at BaseClickHouseTest.java:134
> 29 tests completed, 4 failed
> > Task :sdks:java:io:clickhouse:test FAILED



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to