[
https://issues.apache.org/jira/browse/BEAM-12009?focusedWorklogId=583760&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-583760
]
ASF GitHub Bot logged work on BEAM-12009:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Apr/21 20:01
Start Date: 15/Apr/21 20:01
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #14476:
URL: https://github.com/apache/beam/pull/14476#discussion_r614355368
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/BeamJavaUdfCalcRule.java
##########
@@ -122,7 +122,7 @@ public RelNode convert(RelNode rel) {
* Returns true only if the literal can be correctly implemented by {@link
* org.apache.beam.sdk.extensions.sql.impl.rel.BeamCalcRel} in ZetaSQL.
*/
- private static boolean udfSupportsLiteralType(RelDataType type) {
+ static boolean udfSupportsLiteralType(RelDataType type) {
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 583760)
Time Spent: 1h 40m (was: 1.5h)
> Implement Calc splitting.
> -------------------------
>
> Key: BEAM-12009
> URL: https://issues.apache.org/jira/browse/BEAM-12009
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql-zetasql
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: P2
> Labels: zetasql-java-udf
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> In order to use Java UDFs along with ZetaSQL built-in functions, we will need
> the ability to split a single LogicalCalc into multiple Beam Calc nodes
> (BeamCalcRel and/or BeamZetaSqlCalcRel). We might use
> [CalcRelSplitter|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/rel/rules/CalcRelSplitter.java]
> as a starting point.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
