[
https://issues.apache.org/jira/browse/BEAM-12029?focusedWorklogId=583896&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-583896
]
ASF GitHub Bot logged work on BEAM-12029:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Apr/21 23:06
Start Date: 15/Apr/21 23:06
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #14517:
URL: https://github.com/apache/beam/pull/14517#issuecomment-818347617
#
[Codecov](https://codecov.io/gh/apache/beam/pull/14517?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#14517](https://codecov.io/gh/apache/beam/pull/14517?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(c096110) into
[master](https://codecov.io/gh/apache/beam/commit/35759a7b7661094d1f9b5a34ab00a748feae9f2c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(35759a7) will **decrease** coverage by `0.10%`.
> The diff coverage is `n/a`.
> :exclamation: Current head c096110 differs from pull request most recent
head 41d8d71. Consider uploading reports for the commit 41d8d71 to get more
accurate results
[](https://codecov.io/gh/apache/beam/pull/14517?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14517 +/- ##
==========================================
- Coverage 83.60% 83.49% -0.11%
==========================================
Files 445 449 +4
Lines 58980 59051 +71
==========================================
- Hits 49310 49307 -3
- Misses 9670 9744 +74
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/14517?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...ld/srcs/sdks/python/apache\_beam/utils/histogram.py](https://codecov.io/gh/apache/beam/pull/14517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3V0aWxzL2hpc3RvZ3JhbS5weQ==)
| | |
|
[...ython/apache\_beam/examples/complete/estimate\_pi.py](https://codecov.io/gh/apache/beam/pull/14517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL2NvbXBsZXRlL2VzdGltYXRlX3BpLnB5)
| | |
|
[...eam/runners/interactive/display/display\_manager.py](https://codecov.io/gh/apache/beam/pull/14517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3J1bm5lcnMvaW50ZXJhY3RpdmUvZGlzcGxheS9kaXNwbGF5X21hbmFnZXIucHk=)
| | |
|
[...che\_beam/portability/api/beam\_expansion\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/14517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3BvcnRhYmlsaXR5L2FwaS9iZWFtX2V4cGFuc2lvbl9hcGlfcGIyLnB5)
| | |
|
[...sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/14517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3J1bm5lcnMvZGlyZWN0L2V4ZWN1dG9yLnB5)
| | |
|
[...python/apache\_beam/typehints/typehints\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/14517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL3R5cGVoaW50cy90eXBlaGludHNfdGVzdF9weTMucHk=)
| | |
|
[...e\_beam/io/gcp/internal/clients/storage/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL2djcC9pbnRlcm5hbC9jbGllbnRzL3N0b3JhZ2UvX19pbml0X18ucHk=)
| | |
|
[...dks/python/apache\_beam/ml/gcp/naturallanguageml.py](https://codecov.io/gh/apache/beam/pull/14517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL21sL2djcC9uYXR1cmFsbGFuZ3VhZ2VtbC5weQ==)
| | |
|
[.../srcs/sdks/python/apache\_beam/io/range\_trackers.py](https://codecov.io/gh/apache/beam/pull/14517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2lvL3JhbmdlX3RyYWNrZXJzLnB5)
| | |
|
[.../srcs/sdks/python/apache\_beam/examples/sql\_taxi.py](https://codecov.io/gh/apache/beam/pull/14517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdEAyL3NyYy9zZGtzL3B5dGhvbi90ZXN0LXN1aXRlcy90b3gvcHkzOC9idWlsZC9zcmNzL3Nka3MvcHl0aG9uL2FwYWNoZV9iZWFtL2V4YW1wbGVzL3NxbF90YXhpLnB5)
| | |
| ... and [884
more](https://codecov.io/gh/apache/beam/pull/14517/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/14517?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/14517?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[ef21f16...41d8d71](https://codecov.io/gh/apache/beam/pull/14517?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 583896)
Time Spent: 3h 40m (was: 3.5h)
> WontImplementErrors should reference offending operation or argument and link
> to documentation
> ----------------------------------------------------------------------------------------------
>
> Key: BEAM-12029
> URL: https://issues.apache.org/jira/browse/BEAM-12029
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> For example, instead of WontImplementError(order-sensitive) we should raise:
> {code}
> WontImplementError("fillna(method=ffill) is not supported because it
> order-sensitive, only fillna(method=None) is supported. For more details see
> https://s.apache.org/dataframe-order-sensitive-operations";)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
