[
https://issues.apache.org/jira/browse/BEAM-12029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322545#comment-17322545
] Brian Hulette edited comment on BEAM-12029 at 4/16/21, 12:15 AM: ----------------------------------------------------------------- This is largely completed with pr/14157. There are just a few more WontImplementErrors that I need to make better: - [dot|https://github.com/apache/beam/blob/bb948c16aa9a1ff39f03e1d100e7f66d27931a6c/sdks/python/apache_beam/dataframe/frames.py#L742] - [iloc|https://github.com/apache/beam/blob/bb948c16aa9a1ff39f03e1d100e7f66d27931a6c/sdks/python/apache_beam/dataframe/frames.py#L1233] - [align(copy=False)|https://github.com/apache/beam/blob/bb948c16aa9a1ff39f03e1d100e7f66d27931a6c/sdks/python/apache_beam/dataframe/frames.py#L1270] - [append(verify_integrity=True)|https://github.com/apache/beam/blob/bb948c16aa9a1ff39f03e1d100e7f66d27931a6c/sdks/python/apache_beam/dataframe/frames.py#L1307] - [shift(freq)|https://github.com/apache/beam/blob/bb948c16aa9a1ff39f03e1d100e7f66d27931a6c/sdks/python/apache_beam/dataframe/frames.py#L2062] was (Author: bhulette): This is largely completed with pr/14157. There are just a few more WontImplementErrors that I need to make better: - [dot|https://github.com/apache/beam/blob/bb948c16aa9a1ff39f03e1d100e7f66d27931a6c/sdks/python/apache_beam/dataframe/frames.py#L742] - [iloc|https://github.com/apache/beam/blob/bb948c16aa9a1ff39f03e1d100e7f66d27931a6c/sdks/python/apache_beam/dataframe/frames.py#L1233] - [align(copy=False)|https://github.com/apache/beam/blob/bb948c16aa9a1ff39f03e1d100e7f66d27931a6c/sdks/python/apache_beam/dataframe/frames.py#L1270] - [append(verify_integrity=True)|https://github.com/apache/beam/blob/bb948c16aa9a1ff39f03e1d100e7f66d27931a6c/sdks/python/apache_beam/dataframe/frames.py#L1307] > WontImplementErrors should reference offending operation or argument and link > to documentation > ---------------------------------------------------------------------------------------------- > > Key: BEAM-12029 > URL: https://issues.apache.org/jira/browse/BEAM-12029 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core > Reporter: Brian Hulette > Assignee: Brian Hulette > Priority: P2 > Time Spent: 4h 40m > Remaining Estimate: 0h > > For example, instead of WontImplementError(order-sensitive) we should raise: > {code} > WontImplementError("fillna(method=ffill) is not supported because it > order-sensitive, only fillna(method=None) is supported. For more details see > https://s.apache.org/dataframe-order-sensitive-operations";) > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
