[
https://issues.apache.org/jira/browse/BEAM-2085?focusedWorklogId=585299&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-585299
]
ASF GitHub Bot logged work on BEAM-2085:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/21 18:29
Start Date: 19/Apr/21 18:29
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #14390:
URL: https://github.com/apache/beam/pull/14390#discussion_r616079494
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -456,7 +457,8 @@ def run_pipeline(self, pipeline, options):
self._default_environment = (
environments.DockerEnvironment.from_container_image(
apiclient.get_container_image_from_options(options),
- artifacts=environments.python_sdk_dependencies(options)))
+ artifacts=environments.python_sdk_dependencies(options),
+
resource_hints=environments.resource_hints_from_options(options)))
Review comment:
I thought about it and my conclusion was that it is safer to add options
in both places since:
- Hints are stored in Envrionment
- Environments can be created from Pipeline options and the latter can
supply hints.
- In the future we plan to let users create Envrionments explicitly.
- Not sure whether current interactive runner will always pay attention to
the _root_transform() since it executes/replaces parts of the pipeline.
I did add pipeline-supplied options to the root in:
https://github.com/apache/beam/pull/14390/files#diff-8fbc12ce22548ada33496537fd5ee055d7d6d5c64e10080ece3448e4ae1f6d26R223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 585299)
Time Spent: 20h (was: 19h 50m)
> Transforms could give hints to runners on resource requirements
> ---------------------------------------------------------------
>
> Key: BEAM-2085
> URL: https://issues.apache.org/jira/browse/BEAM-2085
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, runner-core, sdk-java-core
> Affects Versions: Not applicable
> Reporter: Ismaël Mejía
> Assignee: Valentyn Tymofieiev
> Priority: P3
> Labels: Clarified
> Time Spent: 20h
> Remaining Estimate: 0h
>
> As discussed in BEAM-673 runners can allocate workers to accomplish their
> work in a better way if they can take into account some hints from the
> transforms, e.g. a source can hint data locality and with this information
> the runner can allocate the workers in an better way, this can also be the
> case with a particular transform that can suggest to the runner to be
> executed in a worker with a specific resource, e.g. GPU.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
