[
https://issues.apache.org/jira/browse/BEAM-11010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325144#comment-17325144
]
Tomo Suzuki edited comment on BEAM-11010 at 4/20/21, 1:40 PM:
--------------------------------------------------------------
From 0.7.0 to 0.13.2, it got compilation errors:
{noformat}
> Task :sdks:java:io:google-cloud-platform:compileJava
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/SubscriberOptions.java:27:
error: cannot find symbol
import com.google.cloud.pubsublite.internal.wire.CommitterBuilder;
^
symbol: class CommitterBuilder
location: package com.google.cloud.pubsublite.internal.wire
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PublisherCache.java:25:
error: cannot find symbol
import com.google.cloud.pubsublite.PublishMetadata;
^
symbol: class PublishMetadata
location: package com.google.cloud.pubsublite
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PublisherCache.java:41:
error: cannot find symbol
private final HashMap<PublisherOptions, Publisher<PublishMetadata>>
livePublishers =
^
symbol: class PublishMetadata
location: class PublisherCache
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PublisherCache.java:44:
error: cannot find symbol
Publisher<PublishMetadata> get(PublisherOptions options) throws ApiException {
^
symbol: class PublishMetadata
location: class PublisherCache
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PublisherCache.java:69:
error: cannot find symbol
void set(PublisherOptions options, Publisher<PublishMetadata> toCache) {
^
symbol: class PublishMetadata
location: class PublisherCache
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteSink.java:27:
error: cannot find symbol
import com.google.cloud.pubsublite.PublishMetadata;
^
symbol: class PublishMetadata
location: package com.google.cloud.pubsublite
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PublisherOrError.java:21:
error: cannot find symbol
import com.google.cloud.pubsublite.PublishMetadata;
^
symbol: class PublishMetadata
location: package com.google.cloud.pubsublite
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PublisherOrError.java:38:
error: cannot find symbol
abstract Publisher<PublishMetadata> publisher();
^
symbol: class PublishMetadata
location: class PublisherOrError
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PublisherOrError.java:42:
error: cannot find symbol
static PublisherOrError ofPublisher(Publisher<PublishMetadata> p) {
^
symbol: class PublishMetadata
location: class PublisherOrError
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/Publishers.java:23:
error: cannot find symbol
import com.google.cloud.pubsublite.PublishMetadata;
^
symbol: class PublishMetadata
location: package com.google.cloud.pubsublite
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/Publishers.java:38:
error: cannot find symbol
static Publisher<PublishMetadata> newPublisher(PublisherOptions options)
throws ApiException {
^
symbol: class PublishMetadata
location: class Publishers
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PublisherOrError.java:30:
error: Did not generate @AutoOneOf class for
org.apache.beam.sdk.io.gcp.pubsublite.PublisherOrError because it references
undefined types
abstract class PublisherOrError {
^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
12 errors
{noformat}
* [java-pubsublite#482|https://github.com/googleapis/java-pubsublite/pull/482]:
"feat: Change message id on PubsubMessages to be an encoded MessageMetadata and
rename PublishMetadata to MessageMetadata"
This renamed PublishMetadata to MessageMetadata
* [java-pubsublite#475|https://github.com/googleapis/java-pubsublite/pull/475]:
"feat: Add CredentialsProvider to Publisher and Subscriber settings"
This changed CommitterBuilder to CommitterSettings. They are not identical in
usages.
Dpcollins-google gave me
https://github.com/googleapis/java-pubsublite/commit/041b3a567bd1dce87824db7ea87da7c1c0920b53
which "had to make many of the same changes".
{noformat}
> Task :sdks:java:io:google-cloud-platform:compileJava
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/SubscriberOptions.java:104:
error: cannot find symbol
.setContext(PubsubContext.of(FRAMEWORK))
^
symbol: method setContext(PubsubContext)
location: class Builder
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/Publishers.java:46:
error: constructor PartitionCountWatchingPublisher in class
PartitionCountWatchingPublisher cannot be applied to given types;
return new PartitionCountWatchingPublisher(
^
required:
PartitionPublisherFactory,com.google.cloud.pubsublite.internal.RoutingPolicy.Factory,com.google.cloud.pubsublite.internal.wire.PartitionCountWatcher.Factory
found: PartitionCountWatchingPublisherSettings
reason: actual and formal argument lists differ in length
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/Publishers.java:54:
error: cannot find symbol
.setContext(PubsubContext.of(FRAMEWORK))
^
symbol: method setContext(PubsubContext)
location: class Builder
{noformat}
Removed setContext invocation.
{noformat}
> Task :sdks:java:io:google-cloud-platform:compileJava
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/Publishers.java:46:
error: constructor PartitionCountWatchingPublisher in class
PartitionCountWatchingPublisher cannot be applied to given types;
return new PartitionCountWatchingPublisher(
^
required:
PartitionPublisherFactory,com.google.cloud.pubsublite.internal.RoutingPolicy.Factory,com.google.cloud.pubsublite.internal.wire.PartitionCountWatcher.Factory
found: PartitionCountWatchingPublisherSettings
reason: actual and formal argument lists differ in length
{noformat}
PartitionCountWatchingPublisher is now instantiated it's builder's
{{build().instantiate()}} method.
was (Author: suztomo):
From 0.7.0 to 0.13.2, it got compilation errors:
{noformat}
> Task :sdks:java:io:google-cloud-platform:compileJava
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/SubscriberOptions.java:27:
error: cannot find symbol
import com.google.cloud.pubsublite.internal.wire.CommitterBuilder;
^
symbol: class CommitterBuilder
location: package com.google.cloud.pubsublite.internal.wire
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PublisherCache.java:25:
error: cannot find symbol
import com.google.cloud.pubsublite.PublishMetadata;
^
symbol: class PublishMetadata
location: package com.google.cloud.pubsublite
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PublisherCache.java:41:
error: cannot find symbol
private final HashMap<PublisherOptions, Publisher<PublishMetadata>>
livePublishers =
^
symbol: class PublishMetadata
location: class PublisherCache
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PublisherCache.java:44:
error: cannot find symbol
Publisher<PublishMetadata> get(PublisherOptions options) throws ApiException {
^
symbol: class PublishMetadata
location: class PublisherCache
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PublisherCache.java:69:
error: cannot find symbol
void set(PublisherOptions options, Publisher<PublishMetadata> toCache) {
^
symbol: class PublishMetadata
location: class PublisherCache
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteSink.java:27:
error: cannot find symbol
import com.google.cloud.pubsublite.PublishMetadata;
^
symbol: class PublishMetadata
location: package com.google.cloud.pubsublite
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PublisherOrError.java:21:
error: cannot find symbol
import com.google.cloud.pubsublite.PublishMetadata;
^
symbol: class PublishMetadata
location: package com.google.cloud.pubsublite
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PublisherOrError.java:38:
error: cannot find symbol
abstract Publisher<PublishMetadata> publisher();
^
symbol: class PublishMetadata
location: class PublisherOrError
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PublisherOrError.java:42:
error: cannot find symbol
static PublisherOrError ofPublisher(Publisher<PublishMetadata> p) {
^
symbol: class PublishMetadata
location: class PublisherOrError
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/Publishers.java:23:
error: cannot find symbol
import com.google.cloud.pubsublite.PublishMetadata;
^
symbol: class PublishMetadata
location: package com.google.cloud.pubsublite
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/Publishers.java:38:
error: cannot find symbol
static Publisher<PublishMetadata> newPublisher(PublisherOptions options)
throws ApiException {
^
symbol: class PublishMetadata
location: class Publishers
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PublisherOrError.java:30:
error: Did not generate @AutoOneOf class for
org.apache.beam.sdk.io.gcp.pubsublite.PublisherOrError because it references
undefined types
abstract class PublisherOrError {
^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
12 errors
{noformat}
* [java-pubsublite#482|https://github.com/googleapis/java-pubsublite/pull/482]:
"feat: Change message id on PubsubMessages to be an encoded MessageMetadata and
rename PublishMetadata to MessageMetadata"
This renamed PublishMetadata to MessageMetadata
* [java-pubsublite#475|https://github.com/googleapis/java-pubsublite/pull/475]:
"feat: Add CredentialsProvider to Publisher and Subscriber settings"
This changed CommitterBuilder to CommitterSettings. They are not identical in
usages.
Dpcollins-google gave me
https://github.com/googleapis/java-pubsublite/commit/041b3a567bd1dce87824db7ea87da7c1c0920b53
which "had to make many of the same changes".
{noformat}
> Task :sdks:java:io:google-cloud-platform:compileJava
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/SubscriberOptions.java:104:
error: cannot find symbol
.setContext(PubsubContext.of(FRAMEWORK))
^
symbol: method setContext(PubsubContext)
location: class Builder
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/Publishers.java:46:
error: constructor PartitionCountWatchingPublisher in class
PartitionCountWatchingPublisher cannot be applied to given types;
return new PartitionCountWatchingPublisher(
^
required:
PartitionPublisherFactory,com.google.cloud.pubsublite.internal.RoutingPolicy.Factory,com.google.cloud.pubsublite.internal.wire.PartitionCountWatcher.Factory
found: PartitionCountWatchingPublisherSettings
reason: actual and formal argument lists differ in length
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/Publishers.java:54:
error: cannot find symbol
.setContext(PubsubContext.of(FRAMEWORK))
^
symbol: method setContext(PubsubContext)
location: class Builder
{noformat}
Removed setContext invocation.
{noformat}
> Task :sdks:java:io:google-cloud-platform:compileJava
/Users/suztomo/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/Publishers.java:46:
error: constructor PartitionCountWatchingPublisher in class
PartitionCountWatchingPublisher cannot be applied to given types;
return new PartitionCountWatchingPublisher(
^
required:
PartitionPublisherFactory,com.google.cloud.pubsublite.internal.RoutingPolicy.Factory,com.google.cloud.pubsublite.internal.wire.PartitionCountWatcher.Factory
found: PartitionCountWatchingPublisherSettings
reason: actual and formal argument lists differ in length
{noformat}
> Beam Dependency Update Request: com.google.cloud:google-cloud-pubsublite
> ------------------------------------------------------------------------
>
> Key: BEAM-11010
> URL: https://issues.apache.org/jira/browse/BEAM-11010
> Project: Beam
> Issue Type: Sub-task
> Components: dependencies
> Reporter: Beam JIRA Bot
> Priority: P3
> Time Spent: 1h
> Remaining Estimate: 0h
>
> ------------------------- 2020-10-05 12:16:22.002680
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.1.6. The latest version is 0.4.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-10-12 12:17:32.946707
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.1.6. The latest version is 0.4.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-02-08 12:24:12.051486
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.10.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-02-15 12:22:21.398946
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.10.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-02-22 12:20:02.544703
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.10.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-01 12:20:42.879270
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.11.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-08 12:22:30.221914
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.11.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-15 12:24:04.931272
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.11.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-22 12:21:36.885299
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.12.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-29 12:21:24.103712
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.12.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-04-05 12:22:46.599190
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.13.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-04-12 12:24:00.148493
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.13.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-04-19 12:22:29.948524
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.13.2
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
