[ 
https://issues.apache.org/jira/browse/BEAM-11010?focusedWorklogId=586014&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586014
 ]

ASF GitHub Bot logged work on BEAM-11010:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Apr/21 17:13
            Start Date: 20/Apr/21 17:13
    Worklog Time Spent: 10m 
      Work Description: suztomo commented on a change in pull request #14578:
URL: https://github.com/apache/beam/pull/14578#discussion_r616883963



##########
File path: 
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/Uuid.java
##########
@@ -49,6 +50,9 @@ public static Uuid random() {
     } catch (IOException e) {
       throw new RuntimeException("Should never have an IOException since there 
is no io.", e);
     }
-    return Uuid.of(output.toByteString());
+    // Encode to Base64 so the random UUIDs are valid if consumed from the 
Cloud Pub/Sub client.
+    return Uuid.of(
+        ByteString.copyFrom(
+            
Base64.getEncoder().encode(output.toByteString().asReadOnlyByteBuffer())));

Review comment:
       This change comes from 
https://github.com/googleapis/java-pubsublite/pull/552/files
   
   CC: @dpcollins-google 

##########
File path: 
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/SubscribeTransform.java
##########
@@ -44,8 +44,6 @@
 import org.joda.time.Duration;
 
 class SubscribeTransform extends PTransform<PBegin, 
PCollection<SequencedMessage>> {
-  private static final Duration MAX_SLEEP_TIME = Duration.standardMinutes(1);

Review comment:
       This change comes from 
https://github.com/googleapis/java-pubsublite/pull/552/files
   
   CC: @dpcollins-google 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 586014)
    Time Spent: 6h  (was: 5h 50m)

> Beam Dependency Update Request: com.google.cloud:google-cloud-pubsublite
> ------------------------------------------------------------------------
>
>                 Key: BEAM-11010
>                 URL: https://issues.apache.org/jira/browse/BEAM-11010
>             Project: Beam
>          Issue Type: Sub-task
>          Components: dependencies
>            Reporter: Beam JIRA Bot
>            Priority: P3
>          Time Spent: 6h
>  Remaining Estimate: 0h
>
>  ------------------------- 2020-10-05 12:16:22.002680 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-pubsublite. 
>         The current version is 0.1.6. The latest version is 0.4.1 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2020-10-12 12:17:32.946707 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-pubsublite. 
>         The current version is 0.1.6. The latest version is 0.4.1 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2021-02-08 12:24:12.051486 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-pubsublite. 
>         The current version is 0.7.0. The latest version is 0.10.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2021-02-15 12:22:21.398946 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-pubsublite. 
>         The current version is 0.7.0. The latest version is 0.10.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2021-02-22 12:20:02.544703 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-pubsublite. 
>         The current version is 0.7.0. The latest version is 0.10.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2021-03-01 12:20:42.879270 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-pubsublite. 
>         The current version is 0.7.0. The latest version is 0.11.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2021-03-08 12:22:30.221914 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-pubsublite. 
>         The current version is 0.7.0. The latest version is 0.11.1 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2021-03-15 12:24:04.931272 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-pubsublite. 
>         The current version is 0.7.0. The latest version is 0.11.1 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2021-03-22 12:21:36.885299 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-pubsublite. 
>         The current version is 0.7.0. The latest version is 0.12.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2021-03-29 12:21:24.103712 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-pubsublite. 
>         The current version is 0.7.0. The latest version is 0.12.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2021-04-05 12:22:46.599190 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-pubsublite. 
>         The current version is 0.7.0. The latest version is 0.13.1 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2021-04-12 12:24:00.148493 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-pubsublite. 
>         The current version is 0.7.0. The latest version is 0.13.1 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2021-04-19 12:22:29.948524 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-pubsublite. 
>         The current version is 0.7.0. The latest version is 0.13.2 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to