[
https://issues.apache.org/jira/browse/BEAM-12174?focusedWorklogId=586020&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586020
]
ASF GitHub Bot logged work on BEAM-12174:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/21 17:21
Start Date: 20/Apr/21 17:21
Worklog Time Spent: 10m
Work Description: kw2542 commented on a change in pull request #14554:
URL: https://github.com/apache/beam/pull/14554#discussion_r616889688
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/DoFnOp.java
##########
@@ -217,7 +222,9 @@ public void open(
.stateInternalsForKey(null)
.state(StateNamespaces.global(), StateTags.bag(bundleStateId,
windowedValueCoder));
final ExecutableStage executableStage =
ExecutableStage.fromPayload(stagePayload);
- stageBundleFactory =
samzaExecutionContext.getJobBundleFactory().forStage(executableStage);
+ final ExecutableStageContext stageContext =
+ SamzaExecutableStageContextFactory.getInstance().get(jobInfo);
+ stageBundleFactory = stageContext.getStageBundleFactory(executableStage);
Review comment:
Actually Yes, DefaultJobBundleFactory supports Docker, Process, External
and Embeded Environment
You may check
https://github.com/apache/beam/blob/243128a8fc52798e1b58b0cf1a271d95ee7aa241/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactory.java#L118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 586020)
Time Spent: 1h 10m (was: 1h)
> Samza Portable Runner Support
> -----------------------------
>
> Key: BEAM-12174
> URL: https://issues.apache.org/jira/browse/BEAM-12174
> Project: Beam
> Issue Type: New Feature
> Components: runner-samza
> Reporter: Ke Wu
> Assignee: Ke Wu
> Priority: P1
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Update Samza Runner to support Beam Portability Framework.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
