[
https://issues.apache.org/jira/browse/BEAM-2085?focusedWorklogId=586057&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586057
]
ASF GitHub Bot logged work on BEAM-2085:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/21 18:00
Start Date: 20/Apr/21 18:00
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #14390:
URL: https://github.com/apache/beam/pull/14390#discussion_r616918063
##########
File path: sdks/python/apache_beam/transforms/ptransform.py
##########
@@ -422,6 +423,35 @@ def with_output_types(self, type_hint):
validate_composite_type_param(type_hint, 'Type hints for a PTransform')
return super(PTransform, self).with_output_types(type_hint)
+ def with_resource_hints(self, **kwargs): # type: (...) -> PTransform
+ """Adds resource hints to the :class:`PTransform`.
+
+ Resource hints allow users to express constraints on the environment where
+ the transform should be executed. Interpretation of the resource hints is
+ defined by Beam Runners. Runners may ignore unsupported the hints.
+
+ Args:
+ **kwargs: key-value pairs describing hints and their values.
+
+ Raises:
+ ValueError: if provided hints are unknown to the SDK. See
+ :mod:~apache_beam.transforms.resources` for a list of known hints.
+
+ Returns:
+ PTransform: A reference to the instance of this particular
+ :class:`PTransform` object.
+ """
+ self._resource_hints = resources.parse_resource_hints(kwargs)
Review comment:
Good point, thanks. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 586057)
Time Spent: 25h 10m (was: 25h)
> Transforms could give hints to runners on resource requirements
> ---------------------------------------------------------------
>
> Key: BEAM-2085
> URL: https://issues.apache.org/jira/browse/BEAM-2085
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, runner-core, sdk-java-core
> Affects Versions: Not applicable
> Reporter: Ismaël Mejía
> Assignee: Valentyn Tymofieiev
> Priority: P3
> Labels: Clarified
> Time Spent: 25h 10m
> Remaining Estimate: 0h
>
> As discussed in BEAM-673 runners can allocate workers to accomplish their
> work in a better way if they can take into account some hints from the
> transforms, e.g. a source can hint data locality and with this information
> the runner can allocate the workers in an better way, this can also be the
> case with a particular transform that can suggest to the runner to be
> executed in a worker with a specific resource, e.g. GPU.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
