[
https://issues.apache.org/jira/browse/BEAM-4776?focusedWorklogId=200879&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-200879
]
ASF GitHub Bot logged work on BEAM-4776:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Feb/19 20:59
Start Date: 19/Feb/19 20:59
Worklog Time Spent: 10m
Work Description: ryan-williams commented on pull request #7890:
[BEAM-4776] consolidate MetricResult implementations
URL: https://github.com/apache/beam/pull/7890
(factored out of #7823)
This simplifies something I found most confusing while learning how the Java
SDK metrics worked: there were many implementations of `MetricResult` laying
around, all with *almost* the same semantics (and a fair amount of copy-paste
having happened between them).
I think I've reduced this to a minimal interface here:
- keyed by "step name" (`@Nullable`, for pcollection-scoped system metrics;
first-class support of these is coming in #7823) and `MetricName` (namespace,
name)
- containing an "attempted" value and (possibly `null` / "unsupported")
"committed" value
- `throw`s `UnsupportedOperationException` on attempting to access
absent/unsupported "committed" value
- buildable from `MetricUpdate`s, including a transient interim step where
"attempted" but not "committed" may be set, for a `MetricResult` that will
ultimately contain both.
- `MetricsContainerStepMap` in particular had [one `MetricResult`
implementation](https://github.com/apache/beam/compare/master...ryan-williams:ac?expand=1#diff-7fd541906a9e771c3312b75947e969daL413)
(that was already basically redundant with others in the codebase), and
[another just like
it](https://github.com/apache/beam/compare/master...ryan-williams:ac?expand=1#diff-7fd541906a9e771c3312b75947e969daL460)
that acted as an unofficial sort of "builder"; both are gone now.
R: @robertwb, @ajamato
I'll CC @mxm @tweise as well since I've sent a bunch to Robert/Alex on this
topic, and this one doesn't directly involve the new metrics API design
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
See [.test-infra/jenkins/README](../.test-infra/jenkins/README.md) for
trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 200879)
Time Spent: 1h 10m (was: 1h)
> Java PortableRunner should support metrics
> ------------------------------------------
>
> Key: BEAM-4776
> URL: https://issues.apache.org/jira/browse/BEAM-4776
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Eugene Kirpichov
> Assignee: Ryan Williams
> Priority: Major
> Labels: triaged
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> BEAM-4775 concerns adding metrics to the JobService API; the current issue is
> about making PortableRunner understand them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
