[ 
https://issues.apache.org/jira/browse/BEAM-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326116#comment-17326116
 ] 

Yifan Mai commented on BEAM-11196:
----------------------------------

I think the current solution is reasonable: when we fuse / combiner-pack 
stages, if they don't have the same parent, we set their parent to their LCA 
(with some caveats). This works most of the time.

It is possible to write exotic PTransforms that causes this heuristic to break 
(i.e. causes the data dependency graph to not be a DAG after this parent 
rewriting) but this is very rare and I have not seen any use issues arising 
from this. So I will mark this as closed.

> Composite transform structure not preserved with fusion.
> --------------------------------------------------------
>
>                 Key: BEAM-11196
>                 URL: https://issues.apache.org/jira/browse/BEAM-11196
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Robert Bradshaw
>            Priority: P3
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> This causes problems with combiner packing, among other things.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to