[
https://issues.apache.org/jira/browse/BEAM-12197?focusedWorklogId=586542&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586542
]
ASF GitHub Bot logged work on BEAM-12197:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/21 13:01
Start Date: 21/Apr/21 13:01
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on a change in pull request
#14585:
URL: https://github.com/apache/beam/pull/14585#discussion_r617510945
##########
File path:
sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsParametersReader.java
##########
@@ -17,17 +17,25 @@
*/
package org.apache.beam.sdk.tpcds;
+import java.util.ArrayList;
+import java.util.Arrays;
import java.util.HashSet;
+import java.util.List;
import java.util.Set;
import java.util.stream.Collectors;
import java.util.stream.Stream;
/** Get and check the TpcdsOptions' parameters, throw exceptions when user
input is invalid. */
public class TpcdsParametersReader {
+
/** The data sizes that have been supported. */
private static final Set<String> supportedDataSizes =
Stream.of("1G", "10G",
"100G").collect(Collectors.toCollection(HashSet::new));
+ private static final String QUERY_PREFIX = "query";
+
+ public static final List<String> SUPPORTED_QUERIES = getSupportedQueries();
Review comment:
I renamed it to `ALL_QUERY_NAMES` since this list contains only query
names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 586542)
Time Spent: 1h (was: 50m)
> TPC-DS: Fix SQL-queries syntax
> -------------------------------
>
> Key: BEAM-12197
> URL: https://issues.apache.org/jira/browse/BEAM-12197
> Project: Beam
> Issue Type: Improvement
> Components: testing-tpcds
> Reporter: Alexey Romanenko
> Assignee: Alexey Romanenko
> Priority: P3
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
