[
https://issues.apache.org/jira/browse/BEAM-2085?focusedWorklogId=586871&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586871
]
ASF GitHub Bot logged work on BEAM-2085:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/21 20:11
Start Date: 21/Apr/21 20:11
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #14607:
URL: https://github.com/apache/beam/pull/14607#discussion_r617844777
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java
##########
@@ -503,7 +509,16 @@ public void
visitPrimitiveTransform(TransformHierarchy.Node node) {
node.getFullName());
LOG.debug("Translating {}", transform);
currentTransform = node.toAppliedPTransform(getPipeline());
+ ResourceHints hints = transform.getResourceHints();
+ // AppliedPTransform instance stores resource hints of current transform
merged with outer
+ // hints (e.g. set on outer composites).
+ // Translation reads resource hints from PTransform objects, so update
the hints.
+ transform.setResourceHints(currentTransform.getResourceHints());
translator.translate(transform, this);
Review comment:
This seemed to be the least invasive change to pass the information
given current interface.
```
public interface TransformTranslator<TransformT extends PTransform> {
void translate(TransformT transform, TranslationContext context);
```
that is used in a lot of places. I recommend to leave it like this, but if
you think we need to change the interface we can file a Jira to revisit this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 586871)
Time Spent: 33h 10m (was: 33h)
> Transforms could give hints to runners on resource requirements
> ---------------------------------------------------------------
>
> Key: BEAM-2085
> URL: https://issues.apache.org/jira/browse/BEAM-2085
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, runner-core, sdk-java-core
> Affects Versions: Not applicable
> Reporter: Ismaël Mejía
> Assignee: Valentyn Tymofieiev
> Priority: P3
> Labels: Clarified
> Time Spent: 33h 10m
> Remaining Estimate: 0h
>
> As discussed in BEAM-673 runners can allocate workers to accomplish their
> work in a better way if they can take into account some hints from the
> transforms, e.g. a source can hint data locality and with this information
> the runner can allocate the workers in an better way, this can also be the
> case with a particular transform that can suggest to the runner to be
> executed in a worker with a specific resource, e.g. GPU.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
