[
https://issues.apache.org/jira/browse/BEAM-12091?focusedWorklogId=586967&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586967
]
ASF GitHub Bot logged work on BEAM-12091:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/21 23:52
Start Date: 21/Apr/21 23:52
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#14520:
URL: https://github.com/apache/beam/pull/14520#discussion_r617968582
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/SparkPipelineRunner.java
##########
@@ -115,13 +114,6 @@ public PortablePipelineResult run(RunnerApi.Pipeline
pipeline, JobInfo jobInfo)
: GreedyPipelineFuser.fuse(trimmedPipeline).toPipeline();
// File staging.
- if (pipelineOptions.getFilesToStage() == null) {
- pipelineOptions.setFilesToStage(
- detectClassPathResourcesToStage(
- SparkPipelineRunner.class.getClassLoader(), pipelineOptions));
- LOG.info(
- "PipelineOptions.filesToStage was not specified. Defaulting to files
from the classpath");
- }
Review comment:
I think removing this broke Python PostCommits, see BEAM-12207. We're
getting an NPE from the LOG statement below, presumably because
`pipelineOptions.getFilesToStage() == null`. I'm not sure what the appropriate
fix is, is it expected that now the null checking happens somewhere else, or
should we add a null check back here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 586967)
Time Spent: 2h 40m (was: 2.5h)
> Make file staging uniform among runners
> ---------------------------------------
>
> Key: BEAM-12091
> URL: https://issues.apache.org/jira/browse/BEAM-12091
> Project: Beam
> Issue Type: Improvement
> Components: runner-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: P2
> Fix For: 2.30.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
