[ 
https://issues.apache.org/jira/browse/BEAM-11994?focusedWorklogId=586992&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586992
 ]

ASF GitHub Bot logged work on BEAM-11994:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Apr/21 01:19
            Start Date: 22/Apr/21 01:19
    Worklog Time Spent: 10m 
      Work Description: ajamato commented on a change in pull request #14489:
URL: https://github.com/apache/beam/pull/14489#discussion_r617996140



##########
File path: 
examples/java/src/main/java/org/apache/beam/examples/cookbook/BigQueryTornadoes.java
##########
@@ -151,6 +154,24 @@ public void processElement(ProcessContext c) {
 
     void setReadMethod(TypedRead.Method value);
 
+    @Description("Mode to use when writing to BigQuery")
+    @Default.Enum("DEFAULT")
+    BigQueryIO.Write.Method getWriteMethod();
+
+    void setWriteMethod(BigQueryIO.Write.Method value);
+
+    @Description("Mode to use when writing to BigQuery")

Review comment:
       Done.

##########
File path: 
examples/java/src/main/java/org/apache/beam/examples/cookbook/BigQueryTornadoes.java
##########
@@ -151,6 +154,24 @@ public void processElement(ProcessContext c) {
 
     void setReadMethod(TypedRead.Method value);
 
+    @Description("Mode to use when writing to BigQuery")
+    @Default.Enum("DEFAULT")
+    BigQueryIO.Write.Method getWriteMethod();
+
+    void setWriteMethod(BigQueryIO.Write.Method value);
+
+    @Description("Mode to use when writing to BigQuery")
+    @Default.Enum("WRITE_TRUNCATE")
+    BigQueryIO.Write.WriteDisposition getWriteDisposition();
+
+    void setWriteDisposition(BigQueryIO.Write.WriteDisposition value);
+
+    @Description("Table Creation mode to use when writing to BigQuery")

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 586992)
    Time Spent: 6h 10m  (was: 6h)

> Java BigQuery - Implement IO Request Count metrics
> --------------------------------------------------
>
>                 Key: BEAM-11994
>                 URL: https://issues.apache.org/jira/browse/BEAM-11994
>             Project: Beam
>          Issue Type: Test
>          Components: io-java-gcp
>            Reporter: Alex Amato
>            Assignee: Alex Amato
>            Priority: P2
>          Time Spent: 6h 10m
>  Remaining Estimate: 0h
>
> Reference PRs (See BigQuery IO example) and detailed explanation of what's 
> needed to instrument this IO with Request Count metrics is found in this 
> handoff doc:
> [https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'|https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'?authuser=0]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to