[ 
https://issues.apache.org/jira/browse/BEAM-12212?focusedWorklogId=587449&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587449
 ]

ASF GitHub Bot logged work on BEAM-12212:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Apr/21 19:15
            Start Date: 22/Apr/21 19:15
    Worklog Time Spent: 10m 
      Work Description: boyuanzz commented on pull request #14575:
URL: https://github.com/apache/beam/pull/14575#issuecomment-825117893


   > Technically/From SDK, yes. I don't think that's a huge issue since we were 
using legacy flag for runner v2, and if you provide a non-official custom 
container for runner v1 it gets rejected regardless. I can add comments if we 
want to make it clearer that this should only be used with portable 
pipelines/official Dataflow images.
   
   Please add this explanation to DataflowPipelineWorkerPoolOptions.java and 
squash all commits into one. Then this PR is ready to go.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 587449)
    Remaining Estimate: 0h
            Time Spent: 10m

> Add sdkContainerImage flag to (eventually) replace workerHarnessContainerImage
> ------------------------------------------------------------------------------
>
>                 Key: BEAM-12212
>                 URL: https://issues.apache.org/jira/browse/BEAM-12212
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-harness, sdk-py-harness
>            Reporter: Emily Ye
>            Assignee: Emily Ye
>            Priority: P2
>              Labels: containers
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> workerHarnessContainerImage (dataflow-only) is a legacy flag from a time 
> where Dataflow packaged the worker and SDK together in on container. As we 
> move towards portable world where remote runners will generally have a 
> containerized SDK process, we wanted a new flag  that can be reused across 
> runners. 
> We want it to reflect that it's only the SDK and remove harness from the 
> name, since "harness" is meaningless to most users ("what are we 
> harnessing?").



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to